You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@crunch.apache.org by "Matthias Friedrich (JIRA)" <ji...@apache.org> on 2012/12/02 15:37:58 UTC

[jira] [Updated] (CRUNCH-122) Make implementation classes package-private

     [ https://issues.apache.org/jira/browse/CRUNCH-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Friedrich updated CRUNCH-122:
--------------------------------------

    Attachment: CRUNCH-122-Make-impl-classes-package-private.patch

That should be most of them but if you find more, be my guest. Some of the avro stuff looks like it could be package-private with some refactoring.
                
> Make implementation classes package-private
> -------------------------------------------
>
>                 Key: CRUNCH-122
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-122
>             Project: Crunch
>          Issue Type: Improvement
>    Affects Versions: 0.4.0
>            Reporter: Matthias Friedrich
>            Assignee: Matthias Friedrich
>            Priority: Trivial
>         Attachments: CRUNCH-122-Make-impl-classes-package-private.patch
>
>
> There are a few implementation classes that are used only from within their home package. Thus, they should be package-private instead of public, which also hides them from javadoc. Most of these classes aren't from our set of "published" packages anyway but it's good style to hide them if we can.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira