[jira] Resolved: (WICKET-1718) WebPage#onAfterRender erroneously reports missing header

["Juergen Donnerstag (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juergen Donnerstag resolved WICKET-1718.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4-RC2

fixed

> WebPage#onAfterRender erroneously reports missing header
> --------------------------------------------------------
>
>                 Key: WICKET-1718
>                 URL: https://issues.apache.org/jira/browse/WICKET-1718
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.4
>            Reporter: Sven Meier
>            Assignee: Juergen Donnerstag
>             Fix For: 1.4-RC2
>
>
> In WebPage#onAfterRender() there's a check wether a header was missing on a page and header contributions would be lost.
> In the following case this check erroneously barks:
> - page A was requested
> - in A's onBeforeRender() a RestartResponseAtInterceptPageException to page B is thrown
> - page A's onAfterRender() is invoked in a finally block
> - processing continues with page B
> Page A's onAfterRender() complains about the missing header, althought his page was never completely rendered.
> IMHO there's a check missing in WebPage#onAfterRender():
>     	if (getRequestCycle().getResponsePage() == this) {
> 		.....
> 	}
> Or is Page A not allowed to throw RestartResponseAtInterceptPageException in onBeforeRender() at all?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.