You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/06/10 18:13:59 UTC
[GitHub] [maven-integration-testing] michael-o opened a new pull request #65: [MNG-6939] ITs fail when MAVENCODEBASE is relative
michael-o opened a new pull request #65:
URL: https://github.com/apache/maven-integration-testing/pull/65
Don't know how to solve it for `cmd`. I am happy with Bourne shell for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] rfscholte commented on pull request #65: [MNG-6939] ITs fail when MAVENCODEBASE is relative
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #65:
URL: https://github.com/apache/maven-integration-testing/pull/65#issuecomment-643142634
Confirmed, I was already quite happy I managed to fix it for `cmd`. Will have another look at it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on pull request #65: [MNG-6939] ITs fail when MAVENCODEBASE is relative
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #65:
URL: https://github.com/apache/maven-integration-testing/pull/65#issuecomment-643458740
Looks good, will add exit code check for the shell script too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on pull request #65: [MNG-6939] ITs fail when MAVENCODEBASE is relative
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #65:
URL: https://github.com/apache/maven-integration-testing/pull/65#issuecomment-642942969
Will try this on Windows...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on pull request #65: [MNG-6939] ITs fail when MAVENCODEBASE is relative
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #65:
URL: https://github.com/apache/maven-integration-testing/pull/65#issuecomment-643468039
Merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on pull request #65: [MNG-6939] ITs fail when MAVENCODEBASE is relative
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #65:
URL: https://github.com/apache/maven-integration-testing/pull/65#issuecomment-643220209
>
>
> Confirmed, I was already quite happy I managed to fix it for `cmd`. Will have another look at it.
It works for me when I remove `setlocal`, but don't know the implications.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on pull request #65: [MNG-6939] ITs fail when MAVENCODEBASE is relative
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #65:
URL: https://github.com/apache/maven-integration-testing/pull/65#issuecomment-643221500
Going through...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o closed pull request #65: [MNG-6939] ITs fail when MAVENCODEBASE is relative
Posted by GitBox <gi...@apache.org>.
michael-o closed pull request #65:
URL: https://github.com/apache/maven-integration-testing/pull/65
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on pull request #65: [MNG-6939] ITs fail when MAVENCODEBASE is relative
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #65:
URL: https://github.com/apache/maven-integration-testing/pull/65#issuecomment-642458225
@olamy Merci, Robert will add a fix for `cmd` onto this branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] rfscholte commented on pull request #65: [MNG-6939] ITs fail when MAVENCODEBASE is relative
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #65:
URL: https://github.com/apache/maven-integration-testing/pull/65#issuecomment-643221055
removing setlocal meant you couldn't run it for a second time. Hence I introduced a new internal variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org