You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "jbonofre (via GitHub)" <gi...@apache.org> on 2023/06/21 09:48:50 UTC
[GitHub] [activemq] jbonofre opened a new pull request, #1036: [AMQ-8149] Add tooling to create activemq docker image (including mul…
jbonofre opened a new pull request, #1036:
URL: https://github.com/apache/activemq/pull/1036
…ti-platform support)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] mattrpav commented on a diff in pull request #1036: [AMQ-8149] Add tooling to create activemq docker image (including multi-platform support)
Posted by "mattrpav (via GitHub)" <gi...@apache.org>.
mattrpav commented on code in PR #1036:
URL: https://github.com/apache/activemq/pull/1036#discussion_r1242650760
##########
assembly/src/docker/docker-compose.yml:
##########
@@ -0,0 +1,39 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+version: "2.1"
+services:
+ activemq:
+ image: ${ACTIVEMQ_DOCKER_IMAGE_NAME:-qctivemq}
Review Comment:
Looks like minor type-o here. Should be 'activemq' instead of 'qctivemq'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] jbonofre merged pull request #1036: [AMQ-8149] Add tooling to create activemq docker image (including multi-platform support)
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre merged PR #1036:
URL: https://github.com/apache/activemq/pull/1036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq] jbonofre commented on pull request #1036: [AMQ-8149] Add tooling to create activemq docker image (including multi-platform support)
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #1036:
URL: https://github.com/apache/activemq/pull/1036#issuecomment-1608128970
@mattrpav good catch, I will fix that. Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org