[jira] [Commented] (THRIFT-1462) add more strict compiler flags

["Jake Farrell (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167826#comment-13167826 ] 

Jake Farrell commented on THRIFT-1462:
--------------------------------------

only concern would be breaking older compilers, if we can document a starting version and above for a supported compiler i'm good with this
                
> add more strict compiler flags
> ------------------------------
>
>                 Key: THRIFT-1462
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1462
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: C++ - Compiler, C++ - Library
>            Reporter: Roger Meier
>         Attachments: THRIFT-1462_flags_c++0x_pedantic_Wextra.patch
>
>
> I would like to introduce additional compiler flags to improve the C++ code quality:
> {noformat}
> -CXXFLAGS = -Wall
> +CXXFLAGS = -Wall -Wextra -std=c++0x -pedantic
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira