You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Chuan Liu <ch...@microsoft.com> on 2014/05/02 23:16:01 UTC

Review Request 21026: Remove HDFS check in tez/DagUtils

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21026/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-7009
    https://issues.apache.org/jira/browse/HIVE-7009


Repository: hive-git


Description
-------

Removed all the DFS checks in the change. They should not impact any functionality.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java abbf38f 

Diff: https://reviews.apache.org/r/21026/diff/


Testing
-------

Manually tested on a cluster deployed in Windows Azure environment.


Thanks,

Chuan Liu

Re: Review Request 21026: Remove HDFS check in tez/DagUtils

Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21026/#review42080
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java
<https://reviews.apache.org/r/21026/#comment75826>

    Just a proposal: in place of throwing exception, you could LOG info/debug something telling what type of FS is utilized. This might help to debug if someone used  (intentionally or mistakenly) unsupported FS . 
    
    


- Mohammad Islam


On May 2, 2014, 9:16 p.m., Chuan Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21026/
> -----------------------------------------------------------
> 
> (Updated May 2, 2014, 9:16 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-7009
>     https://issues.apache.org/jira/browse/HIVE-7009
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Removed all the DFS checks in the change. They should not impact any functionality.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java abbf38f 
> 
> Diff: https://reviews.apache.org/r/21026/diff/
> 
> 
> Testing
> -------
> 
> Manually tested on a cluster deployed in Windows Azure environment.
> 
> 
> Thanks,
> 
> Chuan Liu
> 
>