You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Alok Lal <al...@hortonworks.com> on 2015/09/15 02:29:49 UTC
Re: Review Request 38142: Simplify error messages that would be show
by the GUI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38142/
-----------------------------------------------------------
(Updated Sept. 14, 2015, 5:29 p.m.)
Review request for ranger, Gautam Borad and Madhan Neethiraj.
Changes
-------
Addressed rework comments.
Bugs: RANGER-632
https://issues.apache.org/jira/browse/RANGER-632
Repository: ranger
Description
-------
I have simplied the error messages that would be show to the user on the GUI. Accordingly following class of messages are left unchanged.
- Interal error messages are left unchanged.
- service-def messages are left unchanged
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java b458394
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java da817c6
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/ValidationFailureDetails.java a0e8573
Diff: https://reviews.apache.org/r/38142/diff/
Testing
-------
Existing tests work. Ad-hoc REST api testing.
Thanks,
Alok Lal
Re: Review Request 38142: Simplify error messages that would be show
by the GUI
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38142/#review98981
-----------------------------------------------------------
Ship it!
Please review and update for the comment.
agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java (line 75)
<https://reviews.apache.org/r/38142/#comment155769>
"for this type of service": I think this phrase should either be removed or service-type should be added - like "for {1} service" {1} ==> service-type (hdfs/hive/hbase/knox/..).
Please review the other such messages as well.
- Madhan Neethiraj
On Sept. 15, 2015, 12:29 a.m., Alok Lal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38142/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2015, 12:29 a.m.)
>
>
> Review request for ranger, Gautam Borad and Madhan Neethiraj.
>
>
> Bugs: RANGER-632
> https://issues.apache.org/jira/browse/RANGER-632
>
>
> Repository: ranger
>
>
> Description
> -------
>
> I have simplied the error messages that would be show to the user on the GUI. Accordingly following class of messages are left unchanged.
> - Interal error messages are left unchanged.
> - service-def messages are left unchanged
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java b458394
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java da817c6
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/ValidationFailureDetails.java a0e8573
>
> Diff: https://reviews.apache.org/r/38142/diff/
>
>
> Testing
> -------
>
> Existing tests work. Ad-hoc REST api testing.
>
>
> Thanks,
>
> Alok Lal
>
>
Re: Review Request 38142: Simplify error messages that would be show
by the GUI
Posted by Alok Lal <al...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38142/
-----------------------------------------------------------
(Updated Sept. 14, 2015, 10:18 p.m.)
Review request for ranger, Gautam Borad and Madhan Neethiraj.
Changes
-------
Error message about missing mandatory resource levels or incompatible resource hierarchies should show service-def not service.
Bugs: RANGER-632
https://issues.apache.org/jira/browse/RANGER-632
Repository: ranger
Description
-------
I have simplied the error messages that would be show to the user on the GUI. Accordingly following class of messages are left unchanged.
- Interal error messages are left unchanged.
- service-def messages are left unchanged
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java da817c6
Diff: https://reviews.apache.org/r/38142/diff/
Testing
-------
Existing tests work. Ad-hoc REST api testing.
Thanks,
Alok Lal
Re: Review Request 38142: Simplify error messages that would be show
by the GUI
Posted by Madhan Neethiraj <ma...@apache.org>.
> On Sept. 15, 2015, 3:24 a.m., Madhan Neethiraj wrote:
> > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java, line 350
> > <https://reviews.apache.org/r/38142/diff/3/?file=1073367#file1073367line350>
> >
> > Wouldn't service-type be a better value instead of service-name? For example:
> >
> > "Invalid resoures specified. hbasedev policy can specify values for the following resources: table/column-family/column"
> >
> > vs
> >
> > "Invalid resoures specified. hbase policy can specify values for the following resources: table/column-family/column"
>
> Alok Lal wrote:
> Since the error message is not related to service but its type, I felt that having service type would be better. Mandatory fields and service hierarchies are due to a service's type. But I will change it if you feel strongly about it.
I agree with you. What does policy.getService() return? Service name (like hbasedev) or service-type (like hbase)?
- Madhan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38142/#review98984
-----------------------------------------------------------
On Sept. 15, 2015, 3:10 a.m., Alok Lal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38142/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2015, 3:10 a.m.)
>
>
> Review request for ranger, Gautam Borad and Madhan Neethiraj.
>
>
> Bugs: RANGER-632
> https://issues.apache.org/jira/browse/RANGER-632
>
>
> Repository: ranger
>
>
> Description
> -------
>
> I have simplied the error messages that would be show to the user on the GUI. Accordingly following class of messages are left unchanged.
> - Interal error messages are left unchanged.
> - service-def messages are left unchanged
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java b458394
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java da817c6
>
> Diff: https://reviews.apache.org/r/38142/diff/
>
>
> Testing
> -------
>
> Existing tests work. Ad-hoc REST api testing.
>
>
> Thanks,
>
> Alok Lal
>
>
Re: Review Request 38142: Simplify error messages that would be show
by the GUI
Posted by Alok Lal <al...@hortonworks.com>.
> On Sept. 14, 2015, 8:24 p.m., Madhan Neethiraj wrote:
> > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java, line 350
> > <https://reviews.apache.org/r/38142/diff/3/?file=1073367#file1073367line350>
> >
> > Wouldn't service-type be a better value instead of service-name? For example:
> >
> > "Invalid resoures specified. hbasedev policy can specify values for the following resources: table/column-family/column"
> >
> > vs
> >
> > "Invalid resoures specified. hbase policy can specify values for the following resources: table/column-family/column"
>
> Alok Lal wrote:
> Since the error message is not related to service but its type, I felt that having service type would be better. Mandatory fields and service hierarchies are due to a service's type. But I will change it if you feel strongly about it.
>
> Madhan Neethiraj wrote:
> I agree with you. What does policy.getService() return? Service name (like hbasedev) or service-type (like hbase)?
Yes, it returns service-name as java String. I know that is a scary name. :)
This Method has been in use in this file. Line # 146, 291, etc.
- Alok
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38142/#review98984
-----------------------------------------------------------
On Sept. 14, 2015, 8:10 p.m., Alok Lal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38142/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 8:10 p.m.)
>
>
> Review request for ranger, Gautam Borad and Madhan Neethiraj.
>
>
> Bugs: RANGER-632
> https://issues.apache.org/jira/browse/RANGER-632
>
>
> Repository: ranger
>
>
> Description
> -------
>
> I have simplied the error messages that would be show to the user on the GUI. Accordingly following class of messages are left unchanged.
> - Interal error messages are left unchanged.
> - service-def messages are left unchanged
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java b458394
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java da817c6
>
> Diff: https://reviews.apache.org/r/38142/diff/
>
>
> Testing
> -------
>
> Existing tests work. Ad-hoc REST api testing.
>
>
> Thanks,
>
> Alok Lal
>
>
Re: Review Request 38142: Simplify error messages that would be show
by the GUI
Posted by Alok Lal <al...@hortonworks.com>.
> On Sept. 14, 2015, 8:24 p.m., Madhan Neethiraj wrote:
> > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java, line 350
> > <https://reviews.apache.org/r/38142/diff/3/?file=1073367#file1073367line350>
> >
> > Wouldn't service-type be a better value instead of service-name? For example:
> >
> > "Invalid resoures specified. hbasedev policy can specify values for the following resources: table/column-family/column"
> >
> > vs
> >
> > "Invalid resoures specified. hbase policy can specify values for the following resources: table/column-family/column"
Since the error message is not related to service but its type, I felt that having service type would be better. Mandatory fields and service hierarchies are due to a service's type. But I will change it if you feel strongly about it.
- Alok
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38142/#review98984
-----------------------------------------------------------
On Sept. 14, 2015, 8:10 p.m., Alok Lal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38142/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 8:10 p.m.)
>
>
> Review request for ranger, Gautam Borad and Madhan Neethiraj.
>
>
> Bugs: RANGER-632
> https://issues.apache.org/jira/browse/RANGER-632
>
>
> Repository: ranger
>
>
> Description
> -------
>
> I have simplied the error messages that would be show to the user on the GUI. Accordingly following class of messages are left unchanged.
> - Interal error messages are left unchanged.
> - service-def messages are left unchanged
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java b458394
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java da817c6
>
> Diff: https://reviews.apache.org/r/38142/diff/
>
>
> Testing
> -------
>
> Existing tests work. Ad-hoc REST api testing.
>
>
> Thanks,
>
> Alok Lal
>
>
Re: Review Request 38142: Simplify error messages that would be show
by the GUI
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38142/#review98984
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java (line 350)
<https://reviews.apache.org/r/38142/#comment155772>
Wouldn't service-type be a better value instead of service-name? For example:
"Invalid resoures specified. hbasedev policy can specify values for the following resources: table/column-family/column"
vs
"Invalid resoures specified. hbase policy can specify values for the following resources: table/column-family/column"
- Madhan Neethiraj
On Sept. 15, 2015, 3:10 a.m., Alok Lal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38142/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2015, 3:10 a.m.)
>
>
> Review request for ranger, Gautam Borad and Madhan Neethiraj.
>
>
> Bugs: RANGER-632
> https://issues.apache.org/jira/browse/RANGER-632
>
>
> Repository: ranger
>
>
> Description
> -------
>
> I have simplied the error messages that would be show to the user on the GUI. Accordingly following class of messages are left unchanged.
> - Interal error messages are left unchanged.
> - service-def messages are left unchanged
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java b458394
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java da817c6
>
> Diff: https://reviews.apache.org/r/38142/diff/
>
>
> Testing
> -------
>
> Existing tests work. Ad-hoc REST api testing.
>
>
> Thanks,
>
> Alok Lal
>
>
Re: Review Request 38142: Simplify error messages that would be show
by the GUI
Posted by Alok Lal <al...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38142/
-----------------------------------------------------------
(Updated Sept. 14, 2015, 8:10 p.m.)
Review request for ranger, Gautam Borad and Madhan Neethiraj.
Changes
-------
Addressed rework comments. Attaching diff for reference and record. I am going to rebase and commit to master & 0.5.
Bugs: RANGER-632
https://issues.apache.org/jira/browse/RANGER-632
Repository: ranger
Description
-------
I have simplied the error messages that would be show to the user on the GUI. Accordingly following class of messages are left unchanged.
- Interal error messages are left unchanged.
- service-def messages are left unchanged
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java b458394
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java da817c6
Diff: https://reviews.apache.org/r/38142/diff/
Testing
-------
Existing tests work. Ad-hoc REST api testing.
Thanks,
Alok Lal