You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/16 20:23:27 UTC

[GitHub] [incubator-nuttx] btashton opened a new issue #1808: CI: Builds should terminate if configure.sh fails instead of moving to build phase

btashton opened a new issue #1808:
URL: https://github.com/apache/incubator-nuttx/issues/1808


   Right now if `./tools/configure.sh` fails the build will continue on to the make phase which will cause all kind of unhelpful error messages.
   
   For example this recent case was ignored because the change looked unrelated to the PR based on the compiler errors:
   
   ```
    + /github/workspace/sources/nuttx/tools/testbuild.sh -j 2 -e '-Wno-cpp -Werror' testlist/arm-11.dat
   ====================================================================================
   Configuration/Tool: stm32f4discovery/hciuart,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
   ------------------------------------------------------------------------------------
     Cleaning...
     Configuring...
   boards/arm/sama5/giant-board/Kconfig:110: syntax error
   boards/arm/sama5/giant-board/Kconfig:109: invalid option
   make: *** [tools/Makefile.unix:471: olddefconfig] Error 1
     Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
   boards/arm/sama5/giant-board/Kconfig:110: syntax error
   boards/arm/sama5/giant-board/Kconfig:109: invalid option
   make: *** [tools/Makefile.unix:471: olddefconfig] Error 1
     Building NuttX...
   In file included from /github/workspace/sources/nuttx/include/arch/chip/irq.h:49,
                    from /github/workspace/sources/nuttx/include/arch/irq.h:38,
                    from /github/workspace/sources/nuttx/include/nuttx/irq.h:53,
                    from /github/workspace/sources/nuttx/include/nuttx/sched.h:40,
                    from /github/workspace/sources/nuttx/include/sched.h:34,
                    from /github/workspace/sources/nuttx/include/spawn.h:47,
                    from ./exec_builtin.c:49:
   ##[error]/github/workspace/sources/nuttx/include/arch/stm32/chip.h:96:4: error: #error "Only one STM32 family must be selected !"
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] v01d commented on issue #1808: CI: Builds should terminate if configure.sh fails instead of moving to build phase

Posted by GitBox <gi...@apache.org>.
v01d commented on issue #1808:
URL: https://github.com/apache/incubator-nuttx/issues/1808#issuecomment-693751413


   I guess adding `set -e` in configure.sh should be enough. Or you think it could be something else?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 closed issue #1808: CI: Builds should terminate if configure.sh fails instead of moving to build phase

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed issue #1808:
URL: https://github.com/apache/incubator-nuttx/issues/1808


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org