You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by on...@apache.org on 2015/11/24 02:20:45 UTC
svn commit: r1716006 -
/poi/trunk/src/java/org/apache/poi/hssf/usermodel/DummyGraphics2d.java
Author: onealj
Date: Tue Nov 24 01:20:45 2015
New Revision: 1716006
URL: http://svn.apache.org/viewvc?rev=1716006&view=rev
Log:
FindBugs MALICIOUS_CODE, finalize method should have protected access
Modified:
poi/trunk/src/java/org/apache/poi/hssf/usermodel/DummyGraphics2d.java
Modified: poi/trunk/src/java/org/apache/poi/hssf/usermodel/DummyGraphics2d.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/usermodel/DummyGraphics2d.java?rev=1716006&r1=1716005&r2=1716006&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/usermodel/DummyGraphics2d.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/usermodel/DummyGraphics2d.java Tue Nov 24 01:20:45 2015
@@ -46,6 +46,8 @@ import java.text.AttributedCharacterIter
import java.util.Arrays;
import java.util.Map;
+import org.apache.poi.util.Internal;
+
public class DummyGraphics2d extends Graphics2D {
private BufferedImage bufimg;
private final Graphics2D g2D;
@@ -706,7 +708,12 @@ public class DummyGraphics2d extends Gra
g2D.fillRoundRect( x, y, width, height, arcWidth, arcHeight );
}
- public void finalize() {
+ // FIXME: should be protected
+ // FindBugs, category MALICIOUS_CODE, FI_PUBLIC_SHOULD_BE_PROTECTED
+ // A class's finalize() method should have protected access, not public
+ @Internal
+ @Override
+ public final void finalize() {
log.println( "finalize():" );
g2D.finalize(); // NOSOLAR
super.finalize();
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org