[jira] [Comment Edited] (IGNITE-5151) Add some warning when offheap eviction occurs

["Ivan Rakov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449747#comment-16449747 ] 

Ivan Rakov edited comment on IGNITE-5151 at 4/24/18 1:00 PM:
-------------------------------------------------------------

[~vinx13], your branch can't compile. I used wrong names in my snippet (warnFirstEvict -> firstEvictWarn, MemoryPolicyConfiguration -> DataRegionConfiguration), here's correct version:
{noformat}
    /**
     * Warns on first eviction.
     */
    private void warnFirstEvict(DataRegionConfiguration plcCfg) {
        if (firstEvictWarn)
            return;

        // Do not move warning output to synchronized block (it causes warning in IDE).
        synchronized (this) {
            if (firstEvictWarn)
                return;

            firstEvictWarn = true;
        }

        U.warn(log, "Page-based evictions started." +
            " You may wish to increase 'maxSize' on page memory policy: " + plcCfg.getName());
    }
{noformat}
Please, fix.


was (Author: ivan.glukos):
[~vinx13], your branch can't compile. I used wrong names in my snippet, here's correct version:
{noformat}
    /**
     * Warns on first eviction.
     */
    private void warnFirstEvict(DataRegionConfiguration plcCfg) {
        if (firstEvictWarn)
            return;

        // Do not move warning output to synchronized block (it causes warning in IDE).
        synchronized (this) {
            if (firstEvictWarn)
                return;

            firstEvictWarn = true;
        }

        U.warn(log, "Page-based evictions started." +
            " You may wish to increase 'maxSize' on page memory policy: " + plcCfg.getName());
    }
{noformat}
Please, fix.

> Add some warning when offheap eviction occurs
> ---------------------------------------------
>
>                 Key: IGNITE-5151
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5151
>             Project: Ignite
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Ksenia Rybakova
>            Assignee: Wuwei Lin
>            Priority: Major
>
> Currently if offheap eviction occurs we are silently losing data. It whould be helpful to have some warning in log as it's done for onheap eviction.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)