You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/06/09 11:52:00 UTC
[jira] [Commented] (SUREFIRE-2177) Use junit-bom instead of single JUnit 5 versions
[ https://issues.apache.org/jira/browse/SUREFIRE-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730934#comment-17730934 ]
ASF GitHub Bot commented on SUREFIRE-2177:
------------------------------------------
scordio commented on PR #663:
URL: https://github.com/apache/maven-surefire/pull/663#issuecomment-1584452936
As far as I can judge, the two failing jobs don't seem to be related to my changes, but let me know in case I should look into something.
> Use junit-bom instead of single JUnit 5 versions
> ------------------------------------------------
>
> Key: SUREFIRE-2177
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2177
> Project: Maven Surefire
> Issue Type: Dependency upgrade
> Components: JUnit 5.x support
> Affects Versions: 3.1.2
> Reporter: Stefano Cordio
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.x-candidate
>
>
> I have noticed from [95e8e95e|https://github.com/apache/maven-surefire/commit/95e8e95ee02ee0e12af70850440bd3d4c053d5db] that the Surefire project declares JUnit dependency versions separately. That commit upgraded the junit-jupiter dependencies to 5.9.3 and the junit-platform dependency to 1.9.2. However, I assume the latter should have been [1.9.3|https://junit.org/junit5/docs/current/user-guide/#dependency-metadata-junit-platform] to stay in line with the [junit-jupiter version|https://junit.org/junit5/docs/current/user-guide/#dependency-metadata-junit-jupiter].
> If keeping the junit-platform version behind is not on purpose, I propose to use instead the [junit-bom|https://junit.org/junit5/docs/current/user-guide/#dependency-metadata-junit-bom] which would coordinate versioning of all the related JUnit modules.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)