You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by lukess <gi...@git.apache.org> on 2017/02/03 02:45:51 UTC

[GitHub] storm pull request #1916: fixed storm-kafka-client test failed

GitHub user lukess opened a pull request:

    https://github.com/apache/storm/pull/1916

    fixed storm-kafka-client test failed

    in order to finish tests for storm-kafka-client

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukess/storm 1.x-branch

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1916.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1916
    
----
commit 0b0487be179515e2b1210aa39b71b203be6fb347
Author: lukess <lu...@gmail.com>
Date:   2017-02-03T02:43:50Z

    fixed storm-kafka-client test failed

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1916: fixed storm-kafka-client test failed

Posted by lukess <gi...@git.apache.org>.
Github user lukess commented on the issue:

    https://github.com/apache/storm/pull/1916
  
    thanks @srdo let me re pr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1916: fixed storm-kafka-client test failed

Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/1916
  
    It looks like Fields has an equals() now to do this https://github.com/apache/storm/blob/1.x-branch/storm-core/src/jvm/org/apache/storm/tuple/Fields.java


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1916: fixed storm-kafka-client test failed

Posted by lukess <gi...@git.apache.org>.
Github user lukess closed the pull request at:

    https://github.com/apache/storm/pull/1916


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---