You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/11 03:51:35 UTC
[GitHub] [apisix-helm-chart] Gallardot opened a new pull request #232: feat(apisix): add timezone and extraEnvVars
Gallardot opened a new pull request #232:
URL: https://github.com/apache/apisix-helm-chart/pull/232
You may need to set the timezone to be consistent with your local time zone, otherwise the apisix's logs may used to retrieve event maybe in wrong timezone.
Also define `extraEnvVars` to allow users to extend additional environment variables
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] Gallardot commented on a change in pull request #232: feat(apisix): add timezone and extraEnvVars
Posted by GitBox <gi...@apache.org>.
Gallardot commented on a change in pull request #232:
URL: https://github.com/apache/apisix-helm-chart/pull/232#discussion_r805660521
##########
File path: charts/apisix/values.yaml
##########
@@ -96,6 +96,16 @@ apisix:
podAntiAffinity:
enabled: false
+ # timezone is the timezone where apisix uses.
+ # For example: "UTC" or "Asia/Shanghai"
+ # This value will be set on apisix container's environment variable TZ.
+ # You may need to set the timezone to be consistent with your local time zone,
+ # otherwise the apisix's logs may used to retrieve event maybe in wrong timezone.
+ timezone: UTC
Review comment:
> Agree with you, would you like to submit another PR to add it?
OK，I will submit another PR first and then deal with the current PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #232: feat(apisix): add timezone and extraEnvVars
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #232:
URL: https://github.com/apache/apisix-helm-chart/pull/232#discussion_r805288277
##########
File path: charts/apisix/values.yaml
##########
@@ -96,6 +96,16 @@ apisix:
podAntiAffinity:
enabled: false
+ # timezone is the timezone where apisix uses.
+ # For example: "UTC" or "Asia/Shanghai"
+ # This value will be set on apisix container's environment variable TZ.
+ # You may need to set the timezone to be consistent with your local time zone,
+ # otherwise the apisix's logs may used to retrieve event maybe in wrong timezone.
+ timezone: UTC
+
+ # extraEnvVars An array to add extra env vars
+ extraEnvVars: []
Review comment:
Shall we also add it in the README?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #232: feat(apisix): add timezone and extraEnvVars
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #232:
URL: https://github.com/apache/apisix-helm-chart/pull/232#discussion_r804462072
##########
File path: charts/apisix/values.yaml
##########
@@ -96,6 +96,16 @@ apisix:
podAntiAffinity:
enabled: false
+ # timezone is the timezone where apisix uses.
+ # For example: "UTC" or "Asia/Shanghai"
+ # This value will be set on apisix container's environment variable TZ.
+ # You may need to set the timezone to be consistent with your local time zone,
+ # otherwise the apisix's logs may used to retrieve event maybe in wrong timezone.
+ timezone: UTC
+
+ # extraEnvVars An array to add extra env vars
+ extraEnvVars: []
Review comment:
The format for the key and value should be explained.
##########
File path: charts/apisix/values.yaml
##########
@@ -96,6 +96,16 @@ apisix:
podAntiAffinity:
enabled: false
+ # timezone is the timezone where apisix uses.
+ # For example: "UTC" or "Asia/Shanghai"
+ # This value will be set on apisix container's environment variable TZ.
+ # You may need to set the timezone to be consistent with your local time zone,
+ # otherwise the apisix's logs may used to retrieve event maybe in wrong timezone.
+ timezone: UTC
Review comment:
Should add the documents to explain it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #232: feat(apisix): add timezone and extraEnvVars
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #232:
URL: https://github.com/apache/apisix-helm-chart/pull/232#discussion_r835092597
##########
File path: charts/apisix/README.md
##########
@@ -76,9 +76,10 @@ The following tables lists the configurable parameters of the apisix chart and t
| `apisix.luaModuleHook.configMapRef.name` | Name of the ConfigMap where the lua module codes store | "" |
| `apisix.luaModuleHook.configMapRef.mounts[].key` | Name of the ConfigMap key, for setting the mapping relationship between ConfigMap key and the lua module code path. | `""` |
| `apisix.luaModuleHook.configMapRef.mounts[].path` | Filepath of the plugin code, for setting the mapping relationship between ConfigMap key and the lua module code path. | `""` |
-| `apisix.timezone` | The timezone where APISIX container uses. For example: UTC, Asia/Shanghai. This value will be set on apisix container's environment variable TZ. Sometimes may need to set the timezone to be consistent with local time zone, otherwise the apisix's logs may used to retrieve event maybe in wrong timezone. | `UTC`|
-| `apisix.extraEnvVars` | APISIX container extra environment variables | `[]`|
-
+| `apisix.timezone` | The timezone where APISIX container uses. For example: UTC, Asia/Shanghai. This value will be set on apisix container's environment variable TZ. Sometimes may need to set the timezone to be consistent with local time zone, otherwise the apisix's logs may used to retrieve event maybe in wrong timezone. | nil|
Review comment:
The default value is not `nil`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] Gallardot commented on a change in pull request #232: feat(apisix): add timezone and extraEnvVars
Posted by GitBox <gi...@apache.org>.
Gallardot commented on a change in pull request #232:
URL: https://github.com/apache/apisix-helm-chart/pull/232#discussion_r804577798
##########
File path: charts/apisix/values.yaml
##########
@@ -96,6 +96,16 @@ apisix:
podAntiAffinity:
enabled: false
+ # timezone is the timezone where apisix uses.
+ # For example: "UTC" or "Asia/Shanghai"
+ # This value will be set on apisix container's environment variable TZ.
+ # You may need to set the timezone to be consistent with your local time zone,
+ # otherwise the apisix's logs may used to retrieve event maybe in wrong timezone.
+ timezone: UTC
+
+ # extraEnvVars An array to add extra env vars
+ extraEnvVars: []
Review comment:
Done! PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #232: feat(apisix): add timezone and extraEnvVars
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #232:
URL: https://github.com/apache/apisix-helm-chart/pull/232#discussion_r805288344
##########
File path: charts/apisix/values.yaml
##########
@@ -96,6 +96,16 @@ apisix:
podAntiAffinity:
enabled: false
+ # timezone is the timezone where apisix uses.
+ # For example: "UTC" or "Asia/Shanghai"
+ # This value will be set on apisix container's environment variable TZ.
+ # You may need to set the timezone to be consistent with your local time zone,
+ # otherwise the apisix's logs may used to retrieve event maybe in wrong timezone.
+ timezone: UTC
Review comment:
Agree with you, would you like to submit another PR to add it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] Gallardot commented on a change in pull request #232: feat(apisix): add timezone and extraEnvVars
Posted by GitBox <gi...@apache.org>.
Gallardot commented on a change in pull request #232:
URL: https://github.com/apache/apisix-helm-chart/pull/232#discussion_r835130407
##########
File path: charts/apisix/README.md
##########
@@ -76,9 +76,10 @@ The following tables lists the configurable parameters of the apisix chart and t
| `apisix.luaModuleHook.configMapRef.name` | Name of the ConfigMap where the lua module codes store | "" |
| `apisix.luaModuleHook.configMapRef.mounts[].key` | Name of the ConfigMap key, for setting the mapping relationship between ConfigMap key and the lua module code path. | `""` |
| `apisix.luaModuleHook.configMapRef.mounts[].path` | Filepath of the plugin code, for setting the mapping relationship between ConfigMap key and the lua module code path. | `""` |
-| `apisix.timezone` | The timezone where APISIX container uses. For example: UTC, Asia/Shanghai. This value will be set on apisix container's environment variable TZ. Sometimes may need to set the timezone to be consistent with local time zone, otherwise the apisix's logs may used to retrieve event maybe in wrong timezone. | `UTC`|
-| `apisix.extraEnvVars` | APISIX container extra environment variables | `[]`|
-
+| `apisix.timezone` | The timezone where APISIX container uses. For example: UTC, Asia/Shanghai. This value will be set on apisix container's environment variable TZ. Sometimes may need to set the timezone to be consistent with local time zone, otherwise the apisix's logs may used to retrieve event maybe in wrong timezone. | nil|
Review comment:
Done. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers merged pull request #232: feat(apisix): add timezone and extraEnvVars
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #232:
URL: https://github.com/apache/apisix-helm-chart/pull/232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] Gallardot commented on a change in pull request #232: feat(apisix): add timezone and extraEnvVars
Posted by GitBox <gi...@apache.org>.
Gallardot commented on a change in pull request #232:
URL: https://github.com/apache/apisix-helm-chart/pull/232#discussion_r804577640
##########
File path: charts/apisix/values.yaml
##########
@@ -96,6 +96,16 @@ apisix:
podAntiAffinity:
enabled: false
+ # timezone is the timezone where apisix uses.
+ # For example: "UTC" or "Asia/Shanghai"
+ # This value will be set on apisix container's environment variable TZ.
+ # You may need to set the timezone to be consistent with your local time zone,
+ # otherwise the apisix's logs may used to retrieve event maybe in wrong timezone.
+ timezone: UTC
Review comment:
> Should add the documents to explain it.
I also add this note on the `README` document. I think this explanation document about `timezone` might be more appropriate in the [APISIX FAQ](https://apisix.apache.org/docs/apisix/FAQ). @tokers WDYT？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #232: feat(apisix): add timezone and extraEnvVars
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #232:
URL: https://github.com/apache/apisix-helm-chart/pull/232#discussion_r805288277
##########
File path: charts/apisix/values.yaml
##########
@@ -96,6 +96,16 @@ apisix:
podAntiAffinity:
enabled: false
+ # timezone is the timezone where apisix uses.
+ # For example: "UTC" or "Asia/Shanghai"
+ # This value will be set on apisix container's environment variable TZ.
+ # You may need to set the timezone to be consistent with your local time zone,
+ # otherwise the apisix's logs may used to retrieve event maybe in wrong timezone.
+ timezone: UTC
+
+ # extraEnvVars An array to add extra env vars
+ extraEnvVars: []
Review comment:
Shall we also add it in the README?
##########
File path: charts/apisix/values.yaml
##########
@@ -96,6 +96,16 @@ apisix:
podAntiAffinity:
enabled: false
+ # timezone is the timezone where apisix uses.
+ # For example: "UTC" or "Asia/Shanghai"
+ # This value will be set on apisix container's environment variable TZ.
+ # You may need to set the timezone to be consistent with your local time zone,
+ # otherwise the apisix's logs may used to retrieve event maybe in wrong timezone.
+ timezone: UTC
Review comment:
Agree with you, would you like to submit another PR to add it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] moonming commented on pull request #232: feat(apisix): add timezone and extraEnvVars
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #232:
URL: https://github.com/apache/apisix-helm-chart/pull/232#issuecomment-1078511187
the same as https://github.com/apache/apisix/issues/3039? we can not hard-code TZ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on pull request #232: feat(apisix): add timezone and extraEnvVars
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #232:
URL: https://github.com/apache/apisix-helm-chart/pull/232#issuecomment-1078545680
@Gallardot We may do not set the `TZ` if the value is empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] Gallardot commented on pull request #232: feat(apisix): add timezone and extraEnvVars
Posted by GitBox <gi...@apache.org>.
Gallardot commented on pull request #232:
URL: https://github.com/apache/apisix-helm-chart/pull/232#issuecomment-1078694596
> @Gallardot We may do not set the `TZ` if the value is empty.
@tokers Done. PTAL https://github.com/apache/apisix/pull/6705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org