You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by Marc Logemann <ml...@logemann.org> on 2006/08/25 23:15:26 UTC

deps and javadoc

Hi,

is there a need to have a 3rd party regex lib these days? I am a fan  
of projects not needing too much 3rd party jars.

Also i noticed many invalid javadoc usages like @author tag in method  
doc sections. IMO this is invalid and causes IDEA to turn red which  
in fact is ugly because one first sight this looks like a real java  
error.

--
regards
Marc Logemann
[blog] http://www.logemann.org
[busn] http://www.logentis.de



Re: deps and javadoc

Posted by Marc Logemann <ml...@logemann.org>.
Forget the question, i had to add another dependecy on openjpa-kernel  
for module openjpa-kernel-4, thats all....

--
regards
Marc Logemann
[blog] http://www.logemann.org
[busn] http://www.logentis.de


Am 26.08.2006 um 00:11 schrieb Marc Logemann:

>
> The last thing that wont compile is: ProxyGregorianCalendar4 in  
> module openjpa-kernel4
> This class extends ProxyGregorianCalendar but where do i get this  
> base class?


Re: deps and javadoc

Posted by Marc Logemann <ml...@logemann.org>.
Uhh i didnt know that 1.3 is still supported by OpenJPA. Then forget  
my call, i just wanted to supply a diff where AbstractTestCase use  
JDK regex instead of ORO, but thats obsolete now...

Regarding mvn idea:idea .... ARGH. I just finished setting up my IDEA  
multi-module project by manually resolving all the 3rd party and  
internal dependencies. It even compiles now fully. This is the hard  
way learning what Maven offers :)

The last thing that wont compile is: ProxyGregorianCalendar4 in  
module openjpa-kernel4
This class extends ProxyGregorianCalendar but where do i get this  
base class?
--
regards
Marc Logemann
[blog] http://www.logemann.org
[busn] http://www.logentis.de


Am 25.08.2006 um 23:35 schrieb Patrick Linskey:

>> I will check where the regex
>> are used and see if we could use JDK regex instead.
>> Especially when you setup a new project (when there are no IDE
>> project files *wink* in the repos) you are lucky for every JAR which
>> you dont have to define.
>
> Have you tried out 'mvn idea:idea'? IIRC, it comes pretty close to  
> full
> coverage.
>
> Also, FYI, from what I can tell, we never import regex packages  
> anywhere in
> the codebase.
>
> Finally, recall that OpenJPA supports 1.3 and higher; JDK regex  
> didn't come
> into being until 1.4.
>
> -Patrick
> ______________________________________________________________________ 
> _
> Notice:  This email message, together with any attachments, may  
> contain
> information  of  BEA Systems,  Inc.,  its subsidiaries  and   
> affiliated
> entities,  that may be confidential,  proprietary,  copyrighted   
> and/or
> legally privileged, and is intended solely for the use of the  
> individual
> or entity named in this message. If you are not the intended  
> recipient,
> and have received this message in error, please immediately return  
> this
> by email and then delete it.


RE: deps and javadoc

Posted by Patrick Linskey <pl...@bea.com>.
> I will check where the regex  
> are used and see if we could use JDK regex instead.
> Especially when you setup a new project (when there are no IDE  
> project files *wink* in the repos) you are lucky for every JAR which  
> you dont have to define.

Have you tried out 'mvn idea:idea'? IIRC, it comes pretty close to full
coverage.

Also, FYI, from what I can tell, we never import regex packages anywhere in
the codebase. 

Finally, recall that OpenJPA supports 1.3 and higher; JDK regex didn't come
into being until 1.4.

-Patrick
_______________________________________________________________________
Notice:  This email message, together with any attachments, may contain
information  of  BEA Systems,  Inc.,  its subsidiaries  and  affiliated
entities,  that may be confidential,  proprietary,  copyrighted  and/or
legally privileged, and is intended solely for the use of the individual
or entity named in this message. If you are not the intended recipient,
and have received this message in error, please immediately return this
by email and then delete it.

Re: deps and javadoc

Posted by Marc Logemann <ml...@logemann.org>.
Hi,

ok, good idea regarding the custom tags. I will check where the regex  
are used and see if we could use JDK regex instead.
Especially when you setup a new project (when there are no IDE  
project files *wink* in the repos) you are lucky for every JAR which  
you dont have to define.

--
regards
Marc Logemann
[blog] http://www.logemann.org
[busn] http://www.logentis.de


Am 25.08.2006 um 23:24 schrieb Patrick Linskey:

>
> I usually just add the offending tags to the IDEA list of custom  
> tags. I
> agree that it's annoying, but it's a shame to destroy information  
> just for
> the sake of an IDE.
>


RE: deps and javadoc

Posted by Patrick Linskey <pl...@bea.com>.
> is there a need to have a 3rd party regex lib these days? I am a fan  
> of projects not needing too much 3rd party jars.

Hmm. I don't think that we need the regex stuff in the core product; we
implemented the subset of regexs that we use at runtime on our own.

I think that we rely on the 3rd party package in some of our tests, but
they're not out in OpenJPA yet anyways.

> Also i noticed many invalid javadoc usages like @author tag 
> in method  
> doc sections. IMO this is invalid and causes IDEA to turn red which  
> in fact is ugly because one first sight this looks like a real java  
> error.

I usually just add the offending tags to the IDEA list of custom tags. I
agree that it's annoying, but it's a shame to destroy information just for
the sake of an IDE.

-Patrick
_______________________________________________________________________
Notice:  This email message, together with any attachments, may contain
information  of  BEA Systems,  Inc.,  its subsidiaries  and  affiliated
entities,  that may be confidential,  proprietary,  copyrighted  and/or
legally privileged, and is intended solely for the use of the individual
or entity named in this message. If you are not the intended recipient,
and have received this message in error, please immediately return this
by email and then delete it.