You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/08/23 15:20:54 UTC
[GitHub] [maven] slachiewicz opened a new pull request, #791: [MNG-7531] Upgrade to SLF4J 2.0.0
slachiewicz opened a new pull request, #791:
URL: https://github.com/apache/maven/pull/791
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX`
and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue
title in the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rmannibucau commented on pull request #791: [MNG-7531] Upgrade to SLF4J 2.0.0
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on PR #791:
URL: https://github.com/apache/maven/pull/791#issuecomment-1224256371
Yes, this is what breaks its usage, very often in custom classloader cases and we are to blame since we enabled it so v4 best case (which shouldnt happen since we want to drop the export so maybe slf4j too ;))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #791: [MNG-7531] Upgrade to SLF4J 2.0.0
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #791:
URL: https://github.com/apache/maven/pull/791#issuecomment-1224562124
Please remember: https://issues.apache.org/jira/browse/MNG-6275 and https://issues.apache.org/jira/browse/MNG-6371. Maybe related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slachiewicz commented on pull request #791: [MNG-7531] Upgrade to SLF4J 2.0.0
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on PR #791:
URL: https://github.com/apache/maven/pull/791#issuecomment-1224234757
This is branch for 3.9.0 release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on pull request #791: [MNG-7531] Upgrade to SLF4J 2.0.0
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #791:
URL: https://github.com/apache/maven/pull/791#issuecomment-1224252557
We have exported `org.slf4j` package and `org.slf4j:slf4j-api` artifact - plugin will use what is provided by Maven - should be ok.
Of course IT tests for plugin with 1.7.x and 2x will be appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slachiewicz closed pull request #791: [MNG-7531] Upgrade to SLF4J 2.0.0
Posted by GitBox <gi...@apache.org>.
slachiewicz closed pull request #791: [MNG-7531] Upgrade to SLF4J 2.0.0
URL: https://github.com/apache/maven/pull/791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slachiewicz commented on pull request #791: [MNG-7531] Upgrade to SLF4J 2.0.0
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on PR #791:
URL: https://github.com/apache/maven/pull/791#issuecomment-1224259865
Yes, we export only API, so if plugins wants own implementation - they can use it, why not. Here we change implementation for output and that can be changed globally (we support logback, Log4j2, slf4j and out impl) in maven installation directory (or command line). So if plugin use slf4j simpe v 1.7 it still should work oob i think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] kwin commented on pull request #791: [MNG-7531] Upgrade to SLF4J 2.0.0
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #791:
URL: https://github.com/apache/maven/pull/791#issuecomment-1623811646
> (but there is no new feature for users so really think we can skip it).
I disagree here, https://slf4j.org/manual.html#fluent was added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rmannibucau commented on pull request #791: [MNG-7531] Upgrade to SLF4J 2.0.0
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on PR #791:
URL: https://github.com/apache/maven/pull/791#issuecomment-1224230155
Can we do it in 3.x since it is a breaking change for mojos (the new SPI by itself is one which can breaking functional logs)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #791: [MNG-7531] Upgrade to SLF4J 2.0.0
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #791:
URL: https://github.com/apache/maven/pull/791#issuecomment-1224243953
I don't consider this to be appropriate for 3.x and must be greatly analyzed for 4. I rather see little benefit since too much code is still on Plexus Logging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slachiewicz commented on pull request #791: [MNG-7531] Upgrade to SLF4J 2.0.0
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on PR #791:
URL: https://github.com/apache/maven/pull/791#issuecomment-1224264593
Feel free to use this branch to create own Maven build (as far as we feel should be in good shape for release) to identify problematic plugins or configurations. This way we could add real it tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slachiewicz commented on pull request #791: [MNG-7531] Upgrade to SLF4J 2.0.0
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on PR #791:
URL: https://github.com/apache/maven/pull/791#issuecomment-1224231642
Could you describe where it breaks plugins?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rmannibucau commented on pull request #791: [MNG-7531] Upgrade to SLF4J 2.0.0
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on PR #791:
URL: https://github.com/apache/maven/pull/791#issuecomment-1224382064
Where: it is a work in progress (pr available) but we know we dont promote slf4j - already for 3.x - as a should be used api.
What breaks: plugins location slf4j from .class and creating a custom loader from there. Severals in server area do that but also some forking cause default classloading is not good enough, just test it.
Can be okish for v3 if you add a compat class for 1.7.x loading mecanism if you really want this upgrade (but there is no new feature for users so really think we can skip it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rmannibucau commented on pull request #791: [MNG-7531] Upgrade to SLF4J 2.0.0
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on PR #791:
URL: https://github.com/apache/maven/pull/791#issuecomment-1224239819
@slachiewicz a lot of plugins can - and do - rely on the provided slf4j-api at maven level (since most of the API is sadly exported and available using `ClassRealm` hierarchy). Upgrading to 2.x is not a transparent upgrade, in particular when the mojo overrides the binding (for good or bad reasons). This implies that functional logging will end up in something different (`No SLF4J providers were found.` for ex. Since for v4 `org.slf4j` must not be exposed (replaced by actual logging api and mojo related api) I think we should skip slf4j upgrade until we cleaned up our api leaks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slachiewicz commented on pull request #791: [MNG-7531] Upgrade to SLF4J 2.0.0
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on PR #791:
URL: https://github.com/apache/maven/pull/791#issuecomment-1224272296
@rmannibucau let's be concrete where we have API for logging for V4?
What exact plugins will crash with this slf4j upgrade?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] kwin commented on pull request #791: [MNG-7531] Upgrade to SLF4J 2.0.0
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on PR #791:
URL: https://github.com/apache/maven/pull/791#issuecomment-1623875406
This is not necessarily about logging in Mojos, but about logging in Maven Core itself and in transitive dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #791: [MNG-7531] Upgrade to SLF4J 2.0.0
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #791:
URL: https://github.com/apache/maven/pull/791#issuecomment-1623825720
> > (but there is no new feature for users so really think we can skip it).
>
> I disagree here, https://slf4j.org/manual.html#fluent was added
We haven't even agree on the plugin log API...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org