You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/17 00:39:36 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #34281: [SPARK-37002][PYTHON] Introduce the 'compute.check_identical_indices' option

HyukjinKwon commented on a change in pull request #34281:
URL: https://github.com/apache/spark/pull/34281#discussion_r730197291



##########
File path: python/pyspark/pandas/config.py
##########
@@ -194,6 +194,18 @@ def validate(self, v: Any) -> None:
         default=False,
         types=bool,
     ),
+    Option(
+        key="compute.check_identical_indices",

Review comment:
       I think we should probably have a configuration like `compute.eager_check`, and apply this configuration everywhere when it requires to launch some Spark jobs just for the sake of validation. WDYT @ueshin @itholic @xinrong-databricks ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org