[jira] [Commented] (FLINK-3747) Consolidate TimestampAssigner Methods in Kafka Consumer

["Stephan Ewen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238904#comment-15238904 ] 

Stephan Ewen commented on FLINK-3747:
-------------------------------------

Good catch. Can you open a patch there? Let's fix that fast before people build against the new methods.

> Consolidate TimestampAssigner Methods in Kafka Consumer
> -------------------------------------------------------
>
>                 Key: FLINK-3747
>                 URL: https://issues.apache.org/jira/browse/FLINK-3747
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>            Reporter: Aljoscha Krettek
>            Priority: Blocker
>
> On {{DataStream}} the methods for setting a TimestampAssigner/WatermarkEmitter are called {{assignTimestampsAndWatermarks()}} while on {{FlinkKafkaConsumer*}} they are called {{setPunctuatedWatermarkEmitter()}} and {{setPeriodicWatermarkEmitter()}}.
> I think these names should be matched, also the name {{setWatermarkEmitter}} does not hint at the fact that the assigner primarily assigns timestamps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)