You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2026/10/23 08:31:05 UTC
[PR] Remove stale ssl-config references [pekko-http]
pjfanning opened a new pull request, #1370:
URL: https://github.com/apache/pekko-http/pull/1370
### Motivation
Pekko HTTP no longer depends on Lightbend ssl-config, but a few comments, a test name and the HTTPS docs still referred to it.
### Modification
- `Http.defaultClientHttpsContext` scaladoc: describe the `SSLContext.getDefault` default (configurable through the standard JSSE system properties) instead of ssl-config configuration.
- `server-https-support.md`: drop the recommendation of the ssl-config "Generating X.509 Certificates" guide.
- Rename the `ClientServerSpec` test that mentioned `SSLConfigSettings` (it uses a custom `SSLEngine`), and update two comments in `HttpAPIsTest`.
### Result
Docs and comments no longer point users at ssl-config.
### Tests
- Not run - docs, comments and a test name only
- `sbt http-core/Test/compile http-tests/Test/compile`: pass
- `sbt http-tests/Test/javafmtCheck` (JDK 17): pass
- `sbt docs/paradox`: pass
- `scalafmt --mode diff-ref=upstream/main`: no changes
### References
None - follow-up to the ssl-config removal (akka/akka-http#4278 and akka/akka-http#4303 removed it in Akka HTTP 10.6.0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Remove stale ssl-config references [pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #1370:
URL: https://github.com/apache/pekko-http/pull/1370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Remove stale ssl-config references [pekko-http]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1370:
URL: https://github.com/apache/pekko-http/pull/1370#issuecomment-6370019206
LGTM — docs/comments/test-name cleanup of stale ssl-config references; no code behavior or binary-compat impact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org