[GitHub] [incubator-uniffle] wangao1236 commented on a diff in pull request #521: [ISSUE-496][operator] infer resource request/limit from spec for init container

["wangao1236 (via GitHub)" <gi...@apache.org>]

wangao1236 commented on code in PR #521:
URL: https://github.com/apache/incubator-uniffle/pull/521#discussion_r1091502916


##########
deploy/kubernetes/operator/pkg/controller/util/util.go:
##########
@@ -175,6 +175,7 @@ func GenerateInitContainers(rssPodSpec *v1alpha1.RSSPodSpec) []corev1.Container
 				Privileged: pointer.Bool(true),
 			},
 			VolumeMounts: GenerateHostPathVolumeMounts(rssPodSpec.HostPathMounts),
+			Resources:    rssPodSpec.Resources,

Review Comment:
   Do you want initContainer to use the same request value as the main container?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org