You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/21 00:58:00 UTC
[GitHub] [pulsar] yaalsn opened a new pull request #14390: [CI]Label stable issues and PRs
yaalsn opened a new pull request #14390:
URL: https://github.com/apache/pulsar/pull/14390
### Motivation
This CI workflow can help us to filter the issue and PRs which have `Stable` tag
### Modifications
Add a new CI workflow file called `ci-stable-issue-pr.yaml`
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #14390: [CI]Label stable issues and PRs
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #14390:
URL: https://github.com/apache/pulsar/pull/14390#issuecomment-1048448145
Cool, thanks @yaalsn
Could you please also help put an update in https://lists.apache.org/thread/0lm9tyjqtgtvwkfowkfhbxy24nh8tyxh?
Great news!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #14390: [CI]Label stale issues and PRs
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14390:
URL: https://github.com/apache/pulsar/pull/14390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #14390: [CI]Label stable issues and PRs
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #14390:
URL: https://github.com/apache/pulsar/pull/14390#discussion_r812561006
##########
File path: .github/workflows/ci-stable-issue-pr.yaml
##########
@@ -0,0 +1,18 @@
+name: 'Stale issues and PRs'
+on:
+ schedule:
+ - cron: '30 1 * * *'
+
+jobs:
+ stale:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/stale@v4
+ with:
+ repo-token: ${{ secrets.GITHUB_TOKEN }}
+ stale-issue-message: 'Message to comment on stale issues. If none provided, will not mark issues stale'
+ stale-pr-message: 'Message to comment on stale PRs. If none provided, will not mark PRs stale'
Review comment:
"The PR had no activity for 30 days, mark with Stale label."
##########
File path: .github/workflows/ci-stable-issue-pr.yaml
##########
@@ -0,0 +1,18 @@
+name: 'Stale issues and PRs'
+on:
+ schedule:
+ - cron: '30 1 * * *'
+
+jobs:
+ stale:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/stale@v4
+ with:
+ repo-token: ${{ secrets.GITHUB_TOKEN }}
+ stale-issue-message: 'Message to comment on stale issues. If none provided, will not mark issues stale'
+ stale-pr-message: 'Message to comment on stale PRs. If none provided, will not mark PRs stale'
+ days-before-issue-stale: 30
+ days-before-pr-stale: 45
Review comment:
Follow the discussion in https://lists.apache.org/thread/0lm9tyjqtgtvwkfowkfhbxy24nh8tyxh, it should be 30 days. Of course, I'm not against using 45 days if 45 days is more reasonable.
##########
File path: .github/workflows/ci-stable-issue-pr.yaml
##########
@@ -0,0 +1,18 @@
+name: 'Stale issues and PRs'
+on:
+ schedule:
+ - cron: '30 1 * * *'
+
+jobs:
+ stale:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/stale@v4
+ with:
+ repo-token: ${{ secrets.GITHUB_TOKEN }}
+ stale-issue-message: 'Message to comment on stale issues. If none provided, will not mark issues stale'
+ stale-pr-message: 'Message to comment on stale PRs. If none provided, will not mark PRs stale'
+ days-before-issue-stale: 30
+ days-before-pr-stale: 45
+ days-before-pr-close: -1
+ days-before-issue-close: -1
Review comment:
Use [days-before-close](https://github.com/actions/stale#days-before-close) ?
##########
File path: .github/workflows/ci-stable-issue-pr.yaml
##########
@@ -0,0 +1,18 @@
+name: 'Stale issues and PRs'
+on:
+ schedule:
+ - cron: '30 1 * * *'
+
+jobs:
+ stale:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/stale@v4
+ with:
+ repo-token: ${{ secrets.GITHUB_TOKEN }}
+ stale-issue-message: 'Message to comment on stale issues. If none provided, will not mark issues stale'
+ stale-pr-message: 'Message to comment on stale PRs. If none provided, will not mark PRs stale'
+ days-before-issue-stale: 30
+ days-before-pr-stale: 45
Review comment:
If keep consistent with 30 days, we can only use [days-before-stale](https://github.com/actions/stale#days-before-stale)
##########
File path: .github/workflows/ci-stable-issue-pr.yaml
##########
@@ -0,0 +1,18 @@
+name: 'Stale issues and PRs'
+on:
+ schedule:
+ - cron: '30 1 * * *'
+
+jobs:
+ stale:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/stale@v4
+ with:
+ repo-token: ${{ secrets.GITHUB_TOKEN }}
+ stale-issue-message: 'Message to comment on stale issues. If none provided, will not mark issues stale'
Review comment:
I think the stale message should be
"The issue had no activity for 30 days, mark with Stale label."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yaalsn commented on a change in pull request #14390: [CI]Label stable issues and PRs
Posted by GitBox <gi...@apache.org>.
yaalsn commented on a change in pull request #14390:
URL: https://github.com/apache/pulsar/pull/14390#discussion_r812570010
##########
File path: .github/workflows/ci-stable-issue-pr.yaml
##########
@@ -0,0 +1,18 @@
+name: 'Stale issues and PRs'
+on:
+ schedule:
+ - cron: '30 1 * * *'
+
+jobs:
+ stale:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/stale@v4
+ with:
+ repo-token: ${{ secrets.GITHUB_TOKEN }}
+ stale-issue-message: 'Message to comment on stale issues. If none provided, will not mark issues stale'
+ stale-pr-message: 'Message to comment on stale PRs. If none provided, will not mark PRs stale'
+ days-before-issue-stale: 30
+ days-before-pr-stale: 45
+ days-before-pr-close: -1
+ days-before-issue-close: -1
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yaalsn commented on pull request #14390: [CI]Label stale issues and PRs
Posted by GitBox <gi...@apache.org>.
yaalsn commented on pull request #14390:
URL: https://github.com/apache/pulsar/pull/14390#issuecomment-1048515482
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org