You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/13 19:44:28 UTC

[GitHub] [pulsar] MarvinCai opened a new pull request #8945: Support deliverAt and deliverAfter attribute for Websocket producer.

MarvinCai opened a new pull request #8945:
URL: https://github.com/apache/pulsar/pull/8945


   
   ### Motivation
   
   
   Support deliverAt and deliverAfter attribute for Websocket producer
   
   ### Modifications
   
   Apply deliverAt and deliverAfter to message builder for Websocket message build if not negative.
   
   ### Verifying this change
   
   Added unit test to verify attributes set on message builder.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema: no 
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: no
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] MarvinCai commented on pull request #8945: Support deliverAt and deliverAfter attribute for Websocket producer.

Posted by GitBox <gi...@apache.org>.
MarvinCai commented on pull request #8945:
URL: https://github.com/apache/pulsar/pull/8945#issuecomment-744356234


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #8945: Support deliverAt and deliverAfter attribute for Websocket producer.

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8945:
URL: https://github.com/apache/pulsar/pull/8945


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie commented on pull request #8945: Support deliverAt and deliverAfter attribute for Websocket producer.

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #8945:
URL: https://github.com/apache/pulsar/pull/8945#issuecomment-744155419


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org