You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/11/17 11:21:21 UTC
[GitHub] [openwhisk-release] style95 opened a new pull request #357: Elaborate the release instruction
style95 opened a new pull request #357:
URL: https://github.com/apache/openwhisk-release/pull/357
This is to add more information to release the `openwhisk` repository.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-release] rabbah commented on a change in pull request #357: Elaborate the release instruction
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #357:
URL: https://github.com/apache/openwhisk-release/pull/357#discussion_r525131233
##########
File path: docs/release_instructions.md
##########
@@ -132,13 +167,18 @@ provide historical documentation of project releases.
- repository: URL of the repository
- branch: git branch being released (`master` or a release branch name)
-**Important Note:** If you are releasing a Node.js package which
+**Important Note1:** If you are releasing a Node.js package which
contains a `package.json`, you should make sure the `version`
specified in `package.json` matches your release version. If you
also have a `package-lock.json` file, it too must have a matching
`version` property. See additional tips for [releasing npm
packages](#publishing-to-npm).
+**Important Note2:** If you are releasing the `openwhisk` or `openwhisk-deploy-kube` repositories,
+the branch and commit hash in the release contents should be the release branch and the latest commit hash in the release branch.
+Please be especially noted that they are not from the `master` branch.
Review comment:
```suggestion
Please be careful not to use the `master` branch.
```
##########
File path: docs/release_instructions.md
##########
@@ -132,13 +167,18 @@ provide historical documentation of project releases.
- repository: URL of the repository
- branch: git branch being released (`master` or a release branch name)
-**Important Note:** If you are releasing a Node.js package which
+**Important Note1:** If you are releasing a Node.js package which
Review comment:
```suggestion
**Important Note 1:** If you are releasing a Node.js package which
```
##########
File path: docs/release_instructions.md
##########
@@ -132,13 +167,18 @@ provide historical documentation of project releases.
- repository: URL of the repository
- branch: git branch being released (`master` or a release branch name)
-**Important Note:** If you are releasing a Node.js package which
+**Important Note1:** If you are releasing a Node.js package which
contains a `package.json`, you should make sure the `version`
specified in `package.json` matches your release version. If you
also have a `package-lock.json` file, it too must have a matching
`version` property. See additional tips for [releasing npm
packages](#publishing-to-npm).
+**Important Note2:** If you are releasing the `openwhisk` or `openwhisk-deploy-kube` repositories,
Review comment:
```suggestion
**Important Note 2:** If you are releasing the `openwhisk` or `openwhisk-deploy-kube` repositories,
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-release] style95 merged pull request #357: Elaborate the release instruction
Posted by GitBox <gi...@apache.org>.
style95 merged pull request #357:
URL: https://github.com/apache/openwhisk-release/pull/357
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org