You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "steveloughran (via GitHub)" <gi...@apache.org> on 2023/06/02 16:47:21 UTC
[GitHub] [hbase-filesystem] steveloughran opened a new pull request, #39: HBASE-27900. [HBOSS] Open file fails with NumberFormatException for S3AFileSystem
steveloughran opened a new pull request, #39:
URL: https://github.com/apache/hbase-filesystem/pull/39
This corrects the same bug as HADOOP-18724; overloading of setter by different number types can cause problems. This patch converts all supplied double/float args to long before setting -exactly what the hadoop change does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-filesystem] virajjasani commented on a diff in pull request #39: HBASE-27900. [HBOSS] Open file fails with NumberFormatException for S3AFileSystem
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on code in PR #39:
URL: https://github.com/apache/hbase-filesystem/pull/39#discussion_r1214835438
##########
hbase-oss/src/main/java/org/apache/hadoop/hbase/oss/LockingFSBuilderWrapper.java:
##########
@@ -135,30 +135,53 @@ public B opt(@Nonnull final String key,
@Override
public B opt(@Nonnull final String key, final boolean value) {
- LOG.debug("{}: option {}=\"{}\"", path, key, value);
- wrapped.opt(key, value);
- return getThisBuilder();
+ return opt(key, Boolean.toString(value));
+ }
+
+ /**
+ * sets the long value.
+ * @since Hadoop-3.3.6
+ * Method added in HADOOP-18274.
+ * @param key key
+ * @param value long value
+ * @return the builder
+ */
+ public B optLong(@Nonnull final String key, final long value) {
+ return opt(key, Long.toString(value));
+ }
+
+ /**
+ * Set optional double parameter for the Builder.
+ * @since Hadoop-3.3.6
Review Comment:
shall we mention HADOOP-18724 for all comments with `@since Hadoop-3.3.6`?
##########
hbase-oss/src/main/java/org/apache/hadoop/hbase/oss/LockingFSBuilderWrapper.java:
##########
@@ -135,30 +135,53 @@ public B opt(@Nonnull final String key,
@Override
public B opt(@Nonnull final String key, final boolean value) {
- LOG.debug("{}: option {}=\"{}\"", path, key, value);
- wrapped.opt(key, value);
- return getThisBuilder();
+ return opt(key, Boolean.toString(value));
+ }
+
+ /**
+ * sets the long value.
+ * @since Hadoop-3.3.6
+ * Method added in HADOOP-18274.
Review Comment:
typo? HADOOP-18724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] HBASE-27900. [HBOSS] Open file fails with NumberFormatException for S3AFileSystem [hbase-filesystem]
Posted by "steveloughran (via GitHub)" <gi...@apache.org>.
steveloughran closed pull request #39: HBASE-27900. [HBOSS] Open file fails with NumberFormatException for S3AFileSystem
URL: https://github.com/apache/hbase-filesystem/pull/39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org