You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2020/11/09 22:19:51 UTC

[GitHub] [orc] pgaref opened a new pull request #569: ORC-672: FIX ORC type conversion within arrays where array.length >1024

pgaref opened a new pull request #569:
URL: https://github.com/apache/orc/pull/569


   ### What changes were proposed in this pull request?
   
   Orc type conversion is throwing ArrayIndexOutOfBoundsException when using ColumnVectors larger than 1024.
   The issue is originating from the ConvertTreeReaderFactory where we convert types always using the default CV length instead of the specific batch size.
   
   ### Why are the changes needed?
   
   This PR takes into account batchSize when converting types and adds tests for all possible type conversions (with large batchSize) as part of TestConvertTreeReaderFactory.
   
   ### How was this patch tested?
   
   TestConvertTreeReaderFactory
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #569: ORC-672: FIX ORC type conversion within arrays where array.length >1024

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #569:
URL: https://github.com/apache/orc/pull/569#issuecomment-724336367


   Merged to branch-1.5. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun merged pull request #569: ORC-672: FIX ORC type conversion within arrays where array.length >1024

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #569:
URL: https://github.com/apache/orc/pull/569


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org