[jira] [Commented] (HAMA-723) Implement sorting in spilling queue.

["MaoYuan Xian (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HAMA-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667703#comment-13667703 ] 

MaoYuan Xian commented on HAMA-723:
-----------------------------------

Base on Thomas' cool codes, implemented the sorting spilling queue for my real world project.
Some simple feedback posted here may be helpful to somebody who want to do related implementations: in mergeFiles() function of Merger.java, when merging finished, there is no call to "dos.close()", data lost may happen. Also, in sortAndSpill function of SortedFile.java, os.close() missing.

I changed the codes to java 6 compliance, not sure whether there is problem when run from java 7.

                
> Implement sorting in spilling queue.
> ------------------------------------
>
>                 Key: HAMA-723
>                 URL: https://issues.apache.org/jira/browse/HAMA-723
>             Project: Hama
>          Issue Type: Sub-task
>          Components: bsp core
>            Reporter: Suraj Menon
>             Fix For: 0.7.0
>
>
> Implement sorted queue. The sender queue can send segments of sorted data and the receiver queue should implement merge sort.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira