You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/10/13 03:04:06 UTC
[GitHub] [nifi] TheGreatRandall opened a new pull request, #6522: NIFI-10637 fixing flaky test in TestParseCEF
TheGreatRandall opened a new pull request, #6522:
URL: https://github.com/apache/nifi/pull/6522
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-10637](https://issues.apache.org/jira/browse/NIFI-10637)
Following the problem in the issue NIFI-10637. I dived deep to the class "ValidateLocale" where the validator has been determined valid or not.
After several printouts and checking log files, we found that the available locales is a deterministic list.
```
final Locale[] availableLocales = Locale.getAvailableLocales();
```
However, the if condition in this class looks like this:
```
if (availableLocales[0].equals(testLocale)) {
// Locale matches the "null" locale so it is treated as invalid
return new ValidationResult.Builder().subject(subject).input(input).valid(false)
.explanation(input + " is not a valid locale format.").build();
}
```
The purpose of this if statement is to determine if the testLocale is empty. However, as I said before, the availableLocales is a given list and the first element is not the zero. So I changed the code to this:
```
if ("".equals(testLocale.toString())) {
// Locale matches the "null" locale so it is treated as invalid
return new ValidationResult.Builder().subject(subject).input(input).valid(false)
.explanation(input + " is not a valid locale format.").build();
}
```
By changing this, the if statement can correctly work and the bug has been fixed. It is not flaky anymore and can pass the NonDex's check.
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [X] Pull Request based on current revision of the `main` branch
- [X] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [X] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #6522: NIFI-10637 fixing flaky test in TestParseCEF
Posted by GitBox <gi...@apache.org>.
exceptionfactory closed pull request #6522: NIFI-10637 fixing flaky test in TestParseCEF
URL: https://github.com/apache/nifi/pull/6522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6522: NIFI-10637 fixing flaky test in TestParseCEF
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on code in PR #6522:
URL: https://github.com/apache/nifi/pull/6522#discussion_r995961076
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java:
##########
@@ -396,7 +396,7 @@ public ValidationResult validate(String subject, String input, ValidationContext
final Locale[] availableLocales = Locale.getAvailableLocales();
Review Comment:
It looks like this line could be removed.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] TheGreatRandall commented on a diff in pull request #6522: NIFI-10637 fixing flaky test in TestParseCEF
Posted by GitBox <gi...@apache.org>.
TheGreatRandall commented on code in PR #6522:
URL: https://github.com/apache/nifi/pull/6522#discussion_r999980589
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java:
##########
@@ -396,7 +396,7 @@ public ValidationResult validate(String subject, String input, ValidationContext
final Locale[] availableLocales = Locale.getAvailableLocales();
Review Comment:
Thank you for your feedback! I'll update it very soon!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] TheGreatRandall commented on a diff in pull request #6522: NIFI-10637 fixing flaky test in TestParseCEF
Posted by GitBox <gi...@apache.org>.
TheGreatRandall commented on code in PR #6522:
URL: https://github.com/apache/nifi/pull/6522#discussion_r1002779016
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java:
##########
@@ -396,7 +396,7 @@ public ValidationResult validate(String subject, String input, ValidationContext
final Locale[] availableLocales = Locale.getAvailableLocales();
Review Comment:
hi, I've removed the variable. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org