[jira] [Commented] (SOLR-14915) Prometheus-exporter should not depend on Solr-core

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-14915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239832#comment-17239832 ] 

ASF subversion and git services commented on SOLR-14915:
--------------------------------------------------------

Commit 021de9f45f56259b3d1461595bc6530189255a2a in lucene-solr's branch refs/heads/master from David Smiley
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=021de9f ]

SOLR-14915: Prometheus-exporter should not depend on Solr-core (#1972)

* Reduced dependencies from Solr server down to just SolrJ.  Don't add WEB-INF/lib.
* Was missing some dependencies in lib/; now has all except SolrJ & logging.
* Can run via gradle, "gradlew run"
* Has own log4j2.xml now

Has own CHANGES.md now.

> Prometheus-exporter should not depend on Solr-core
> --------------------------------------------------
>
>                 Key: SOLR-14915
>                 URL: https://issues.apache.org/jira/browse/SOLR-14915
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - prometheus-exporter
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>         Attachments: patch.patch
>
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> I think it's *crazy* that our Prometheus exporter depends on Solr-core -- this thing is a _client_ of Solr; it does not live within Solr.  The exporter ought to be fairly lean.  One consequence of this dependency is that, for example, security vulnerabilities reported against Solr (e.g. Jetty) can (and do, where I work) wind up being reported against this module even though Prometheus isn't using Jetty.
> From my evaluation today of what's going on, it appears the crux of the problem is that the prometheus exporter uses some utility mechanisms in Solr-core like XmlConfig (which depends on SolrResourceLoader and the rabbit hole goes deeper...) and DOMUtils (further depends on PropertiesUtil).  It can easy be made to not use XmlConfig.  DOMUtils & PropertiesUtil could move to SolrJ which already has lots of little dependency-free utilities needed by SolrJ and Solr-core alike.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org