[jira] [Commented] (MESOS-4003) Pass agent work_dir to isolator modules

["Greg Mann (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15049684#comment-15049684 ] 

Greg Mann commented on MESOS-4003:
----------------------------------

In order to prevent breaking the isolator interface in the future when more parameters may be added, a new protobuf message was added and made the sole parameter of {{Isolator::recover()}}.

Review is posted here: https://reviews.apache.org/r/41113/

> Pass agent work_dir to isolator modules
> ---------------------------------------
>
>                 Key: MESOS-4003
>                 URL: https://issues.apache.org/jira/browse/MESOS-4003
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Greg Mann
>            Assignee: Greg Mann
>              Labels: external-volumes, mesosphere
>
> Some isolator modules can benefit from access to the agent's {{work_dir}}. For example, the DVD isolator (https://github.com/emccode/mesos-module-dvdi) is currently forced to mount external volumes in a hard-coded directory. Making the {{work_dir}} accessible to the isolator via {{Isolator::recover()}} would allow the isolator to mount volumes within the agent's {{work_dir}}. This can be accomplished by simply adding an overloaded signature for {{Isolator::recover()}} which includes the {{work_dir}} as a parameter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)