You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/18 02:40:41 UTC
[jira] [Commented] (BEAM-1990) Window.Assign should not be public
since it is not meant to be used publicly
[ https://issues.apache.org/jira/browse/BEAM-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972025#comment-15972025 ]
ASF GitHub Bot commented on BEAM-1990:
--------------------------------------
GitHub user wtanaka opened a pull request:
https://github.com/apache/beam/pull/2564
[BEAM-1990] Make Window.Assign default visibility
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wtanaka/beam window-assign
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2564.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2564
----
commit 8591dc9f4367aa7e11221bf24b85891bfe886979
Author: wtanaka.com <wt...@yahoo.com>
Date: 2017-04-18T01:31:13Z
[BEAM-1990] Make Window.Assign default visibility
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
----
> Window.Assign should not be public since it is not meant to be used publicly
> ----------------------------------------------------------------------------
>
> Key: BEAM-1990
> URL: https://issues.apache.org/jira/browse/BEAM-1990
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Wesley Tanaka
> Assignee: Wesley Tanaka
> Priority: Trivial
>
> It's not clear from the source code (either the visibility or the javadoc) if there are any valid use-cases for using Assign directly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)