[jira] [Commented] (TIKA-3418) DefaultZipContainerDetector does not support loading of ZipContainerDetectors in an OSGi enviroment

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TIKA-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351869#comment-17351869 ] 

ASF GitHub Bot commented on TIKA-3418:
--------------------------------------

simon-shlomo opened a new pull request #446:
URL: https://github.com/apache/tika/pull/446


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for your contribution to [Apache Tika](https://tika.apache.org/)! Your help is appreciated!
   
   Before opening the pull request, please verify that
   * there is an open issue on the [Tika issue tracker](https://issues.apache.org/jira/projects/TIKA) which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
   * the issue ID (`TIKA-XXXX`)
     - is referenced in the title of the pull request
     - and placed in front of your commit messages surrounded by square brackets (`[TIKA-XXXX] Issue or pull request title`)
   * commits are squashed into a single one (or few commits for larger changes)
   * Tika is successfully built and unit tests pass by running `mvn clean test`
   * there should be no conflicts when merging the pull request branch into the *recent* `main` branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled `main` branch.
   
   We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the [Tika mailing list](http://tika.apache.org/mail-lists.html). Thanks!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> DefaultZipContainerDetector does not support loading of ZipContainerDetectors in an OSGi enviroment
> ---------------------------------------------------------------------------------------------------
>
>                 Key: TIKA-3418
>                 URL: https://issues.apache.org/jira/browse/TIKA-3418
>             Project: Tika
>          Issue Type: Improvement
>          Components: core, parser
>    Affects Versions: 2.0.0
>            Reporter: Simon-Shlomo Poil
>            Priority: Major
>
> Classes that implements the ZipContainerDetector interface are loaded via the ServiceLoader in the DefaultZipContainerDetector (in parsers-zip-commons).
> In an OSGi enviroment the current behaviour is (default constructor) to only load classes that a found by the DefaultZipContainerDetector classloader, however this will miss ZipContainerDetector classes such as the [OPCPackageDetector.java|https://github.com/apache/tika/blob/main/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-microsoft-module/src/main/java/org/apache/tika/detect/microsoft/ooxml/OPCPackageDetector.java] in the [tika-parser-microsoft-module|https://github.com/apache/tika/tree/main/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-microsoft-module].
> The DefaultZipConatinerDetector has constructor to pass a ServiceLoader, which in principle could allow loading of dynamic services. However, this constructor will load the services only on initialization, which does comply with the dynamic natur of an OSGi enviroment where services can come and go dynamically.
> Linked to this issue is pull-request that attempts solve this issue following a similar strategy of service loading as implemented in the DefaultDetector and DefaultParser.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)