You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/01/18 13:55:41 UTC

[GitHub] [iotdb] qiaojialin commented on a change in pull request #4887: Update session and JDBC doc about compatible with 0.13

qiaojialin commented on a change in pull request #4887:
URL: https://github.com/apache/iotdb/pull/4887#discussion_r786780240



##########
File path: docs/UserGuide/API/Programming-Java-Native-API.md
##########
@@ -79,9 +79,12 @@ session =
         .thriftDefaultBufferSize(int thriftDefaultBufferSize)
         .thriftMaxFrameSize(int thriftMaxFrameSize)
         .enableCacheLeader(boolean enableCacheLeader)
+        .version(Version version)
         .build();
 ```
 
+Version represents the SQL semantic version used by the client, which is used to be compatible with the SQL semantics of 0.12 when upgrading 0.13. The possible values are: `Version.V_0_12`, `Version.V_0_13`.

Review comment:
       ```suggestion
   Version represents the SQL semantic version used by the client, which is used to be compatible with the SQL semantics of 0.12 when upgrading 0.13. The possible values are: `V_0_12`, `V_0_13`.
   ```

##########
File path: docs/zh/UserGuide/API/Programming-Java-Native-API.md
##########
@@ -82,9 +82,12 @@ session =
         .thriftDefaultBufferSize(int thriftDefaultBufferSize)
         .thriftMaxFrameSize(int thriftMaxFrameSize)
         .enableCacheLeader(boolean enableCacheLeader)
+        .version(Version version)
         .build();
 ```
 
+其中,version 表示客户端使用的 SQL 语义版本,用于升级 0.13 时兼容 0.12 的 SQL 语义,可能取值有:`Version.V_0_12`、`Version.V_0_13`。

Review comment:
       ```suggestion
   其中,version 表示客户端使用的 SQL 语义版本,用于升级 0.13 时兼容 0.12 的 SQL 语义,可能取值有:`V_0_12`、`V_0_13`。
   ```

##########
File path: docs/zh/UserGuide/API/Programming-JDBC.md
##########
@@ -200,3 +200,9 @@ public class JDBCExample {
   }
 }
 ```
+
+可以在 url 中指定 version 参数:
+```java
+String url = "jdbc:iotdb://127.0.0.1:6667?version=V_0_12";
+```
+version 表示客户端使用的 SQL 语义版本,用于升级 0.13 时兼容 0.12 的 SQL 语义,可能取值有:`Version.V_0_12`、`Version.V_0_13`。

Review comment:
       ```suggestion
   version 表示客户端使用的 SQL 语义版本,用于升级 0.13 时兼容 0.12 的 SQL 语义,可能取值有:`V_0_12`、`V_0_13`。
   ```

##########
File path: docs/UserGuide/API/Programming-JDBC.md
##########
@@ -211,3 +211,8 @@ public class JDBCExample {
 }
 ```
 
+The parameter `version` can be used in the url:
+````java
+String url = "jdbc:iotdb://127.0.0.1:6667?version=V_0_12";
+````
+The parameter `version` represents the SQL semantic version used by the client, which is used to be compatible with the SQL semantics of 0.12 when upgrading 0.13. The possible values are: `Version.V_0_12`, `Version.V_0_13`.

Review comment:
       ```suggestion
   The parameter `version` represents the SQL semantic version used by the client, which is used to be compatible with the SQL semantics of 0.12 when upgrading 0.13. The possible values are: `V_0_12`, `V_0_13`.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org