You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2018/06/13 10:18:00 UTC

[jira] [Commented] (HBASE-16490) Fix race condition between SnapshotManager and SnapshotCleaner

    [ https://issues.apache.org/jira/browse/HBASE-16490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510919#comment-16510919 ] 

Hudson commented on HBASE-16490:
--------------------------------

Results for branch branch-1
	[build #347 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/347/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(x) {color:red}-1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/347//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/347//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/347//JDK8_Nightly_Build_Report_(Hadoop2)/]




(x) {color:red}-1 source release artifact{color}
-- See build output for details.


> Fix race condition between SnapshotManager and SnapshotCleaner
> --------------------------------------------------------------
>
>                 Key: HBASE-16490
>                 URL: https://issues.apache.org/jira/browse/HBASE-16490
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Heng Chen
>            Assignee: Heng Chen
>            Priority: Major
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16490.patch, HBASE-16490.v1.patch, HBASE-16490.v2.patch
>
>
> As [~mbertozzi] comments on HBASE-16464,  there maybe race condition between SnapshotManager and SnapshotCleaner.  We should use one lock when create snapshot,  and cleanup should acquire the lock before take action.
> One method is pass HMaster as param into Cleaner through {{FileCleanerDelegate.getDeletableFiles}},  suggestions are welcomed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)