You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/04/20 15:53:00 UTC

[jira] [Commented] (IMPALA-12064) Remove unused toolchain components versions (boost, thrift)

    [ https://issues.apache.org/jira/browse/IMPALA-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714652#comment-17714652 ] 

ASF subversion and git services commented on IMPALA-12064:
----------------------------------------------------------

Commit b4920295ac7ceef3921e879c247f29c584c14b24 in impala's branch refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=b4920295a ]

IMPALA-12063: Upgrade zlib to 1.2.13

This bumps the toolchain version to get zlib 1.2.13,
which contains the fix for CVE-2022-37434.

This toolchain incorporates several changes to clean
up the native-toolchain and remove unnecessary
component builds. As part of this, OpenSSL is no
longer built in the toolchain, so this stops
downloading it. This changes the build to require
OpenSSL 1.0.2 or higher. This doesn't impact anything,
because all supported platforms already used
OpenSSL 1.0.2 or higher. See IMPALA-12064.

Testing:
 - perf-AB-test shows no change in performance for
   ORC with deflate
 - GVO passes

Change-Id: I96efc947534cda8d15d4f440cd6851d397b6562d
Reviewed-on: http://gerrit.cloudera.org:8080/19760
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Remove unused toolchain components versions (boost, thrift)
> -----------------------------------------------------------
>
>                 Key: IMPALA-12064
>                 URL: https://issues.apache.org/jira/browse/IMPALA-12064
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>    Affects Versions: Impala 4.3.0
>            Reporter: Joe McDonnell
>            Assignee: Joe McDonnell
>            Priority: Major
>
> The toolchain build is building some old versions of libraries that are not currently in used. Specifically:
> {noformat}
> boost-1.57.0-p3 (old)
> boost-1.61.0-p2 (old)
> thrift-0.13.0-p4 (never used)
> thrift-0.14.2-p4 (never used)
> openssl 1.0.2 (comes from OS, not toolchain)
> krb5 1.15.1 (comes from OS, not toolchain){noformat}
> While we're here, we need to fix that the Boost build limits itself to -j4:
> {noformat}
>   wrap ./b2 -s"NO_BZIP2=1" $TOOLSET cxxflags="$CXXFLAGS" linkflags="$CXXFLAGS" --prefix=$LOCAL_INSTALL -j4 install{noformat}
> And thrift doesn't go parallel when it now works on recent Thrift versions:
> {noformat}
>   wrap make install # Thrift 0.9.0 doesn't build with -j${BUILD_THREADS}{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org