You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "amoeba (via GitHub)" <gi...@apache.org> on 2023/11/13 22:36:39 UTC

[PR] MINOR: [Docs] Make cards on index page of docs responsive [arrow]

amoeba opened a new pull request, #38693:
URL: https://github.com/apache/arrow/pull/38693

   
   ### Rationale for this change
   
   The text inside the Specifications and Development cards in the docs get squished on mobile or small-viewport devices because their CSS grid definition isn't responsive. Example:
   
   ![arrow apache org_docs_(iPhone SE)](https://github.com/apache/arrow/assets/563/a38faf2a-fb8c-4390-a57c-9ee1d6c33a25)
   
   ### What changes are included in this PR?
   
   This changes this specific use of the [`grid-item`](https://sphinx-design.readthedocs.io/en/latest/grids.html) directive to take advantage of the responsive variant,
   
   > or four numbers for extra-small (<576px), small (768px), medium (992px) and large screens (>1200px),
   
   For the extra-small variant, the grid dynamically switches to a single-column which prevents squishing of the text inside the card. Otherwise a two-column grid is used.
   
   ### Are these changes tested?
   
   Yes, I built the docs in a local conda env and tested that the cards look right at all widths. At narrow widths, it looks like this:
   
   ![devd io_8000_(iPhone XR)](https://github.com/apache/arrow/assets/563/fe417e7f-92b2-42d9-ab74-d242c7c6acae)
   
   
   ### Are there any user-facing changes?
   
   Just to docs, see above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: [Docs] Make cards on index page of docs responsive [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF merged PR #38693:
URL: https://github.com/apache/arrow/pull/38693


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: [Docs] Make cards on index page of docs responsive [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #38693:
URL: https://github.com/apache/arrow/pull/38693#issuecomment-1809916042

   Opened an issue for the docs build failure: https://github.com/apache/arrow/issues/38711


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: [Docs] Make cards on index page of docs responsive [arrow]

Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #38693:
URL: https://github.com/apache/arrow/pull/38693#issuecomment-1814833172

   I've rebased my branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: [Docs] Make cards on index page of docs responsive [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #38693:
URL: https://github.com/apache/arrow/pull/38693#issuecomment-1809668151

   @github-actions crossbow submit preview-docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: [Docs] Make cards on index page of docs responsive [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38693:
URL: https://github.com/apache/arrow/pull/38693#issuecomment-1809670646

   Revision: 8b4ab43b3c1d52cbca7d03b29863f93f31dbe3ec
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-5f711a3fe6](https://github.com/ursacomputing/crossbow/branches/all?query=actions-5f711a3fe6)
   
   |Task|Status|
   |----|------|
   |preview-docs|[![Github Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-5f711a3fe6-github-preview-docs)](https://github.com/ursacomputing/crossbow/actions/runs/6860473195/job/18654366354)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: [Docs] Make cards on index page of docs responsive [arrow]

Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #38693:
URL: https://github.com/apache/arrow/pull/38693#issuecomment-1809301858

   I just pushed https://github.com/apache/arrow/pull/38693/commits/8b4ab43b3c1d52cbca7d03b29863f93f31dbe3ec which makes the same change in the other places we have this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: [Docs] Make cards on index page of docs responsive [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38693:
URL: https://github.com/apache/arrow/pull/38693#issuecomment-1811950398

   Revision: 8b4ab43b3c1d52cbca7d03b29863f93f31dbe3ec
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-50427bf095](https://github.com/ursacomputing/crossbow/branches/all?query=actions-50427bf095)
   
   |Task|Status|
   |----|------|
   |preview-docs|[![Github Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-50427bf095-github-preview-docs)](https://github.com/ursacomputing/crossbow/actions/runs/6874314124/job/18695746199)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: [Docs] Make cards on index page of docs responsive [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #38693:
URL: https://github.com/apache/arrow/pull/38693#issuecomment-1809668087

   This looks great, didn't even know about it! =)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: [Docs] Make cards on index page of docs responsive [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #38693:
URL: https://github.com/apache/arrow/pull/38693#issuecomment-1814094327

   @github-actions crossbow submit preview-docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: [Docs] Make cards on index page of docs responsive [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38693:
URL: https://github.com/apache/arrow/pull/38693#issuecomment-1814097933

   Revision: 8b4ab43b3c1d52cbca7d03b29863f93f31dbe3ec
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-5b59e37ad4](https://github.com/ursacomputing/crossbow/branches/all?query=actions-5b59e37ad4)
   
   |Task|Status|
   |----|------|
   |preview-docs|[![Github Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-5b59e37ad4-github-preview-docs)](https://github.com/ursacomputing/crossbow/actions/runs/6888918318/job/18738847448)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: [Docs] Make cards on index page of docs responsive [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #38693:
URL: https://github.com/apache/arrow/pull/38693#issuecomment-1811947973

   @github-actions crossbow submit preview-docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: [Docs] Make cards on index page of docs responsive [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #38693:
URL: https://github.com/apache/arrow/pull/38693#issuecomment-1814322011

   @amoeba could you rebase the PR please? The docs preview uses the code from this branch not from main as I previously thought.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: [Docs] Make cards on index page of docs responsive [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #38693:
URL: https://github.com/apache/arrow/pull/38693#issuecomment-1814850551

   @github-actions crossbow submit preview-docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: [Docs] Make cards on index page of docs responsive [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #38693:
URL: https://github.com/apache/arrow/pull/38693#issuecomment-1817471439

   After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 8301eb5e26efd55bd03adb46aac4202523deb88a.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/18810209644) has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: [Docs] Make cards on index page of docs responsive [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38693:
URL: https://github.com/apache/arrow/pull/38693#issuecomment-1814856130

   Revision: 278570332b6c8013ee0778dc51e972049d10417b
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-e493b84531](https://github.com/ursacomputing/crossbow/branches/all?query=actions-e493b84531)
   
   |Task|Status|
   |----|------|
   |preview-docs|[![Github Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-e493b84531-github-preview-docs)](https://github.com/ursacomputing/crossbow/actions/runs/6893964707/job/18754735752)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] MINOR: [Docs] Make cards on index page of docs responsive [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #38693:
URL: https://github.com/apache/arrow/pull/38693#issuecomment-1814850387

   Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org