You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2024/09/22 09:49:00 UTC
[Impala-ASF-CR] IMPALA-13395: Adds USE APACHE COMPONENTS=true in all-build-options job
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21842
Change subject: IMPALA-13395: Adds USE_APACHE_COMPONENTS=true in all-build-options job
......................................................................
IMPALA-13395: Adds USE_APACHE_COMPONENTS=true in all-build-options job
The all-build-options-ub2004 job verifies builds with USE_APACHE_HIVE
being true and false. This extends it to use the new var,
USE_APACHE_COMPONENTS intead.
Explicitly set USE_APACHE_* based on the value of USE_APACHE_COMPONENTS
so we won't mess up env vars when switching between builds of different
USE_APACHE_COMPONENTS values.
Change-Id: Ica516a7554bfe9fa0710b5a437c302934a13c08d
---
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
2 files changed, 18 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/21842/1
--
To view, visit http://gerrit.cloudera.org:8080/21842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica516a7554bfe9fa0710b5a437c302934a13c08d
Gerrit-Change-Number: 21842
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-13395: Adds USE APACHE COMPONENTS=true in all-build-options job
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21842 )
Change subject: IMPALA-13395: Adds USE_APACHE_COMPONENTS=true in all-build-options job
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11061/
--
To view, visit http://gerrit.cloudera.org:8080/21842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica516a7554bfe9fa0710b5a437c302934a13c08d
Gerrit-Change-Number: 21842
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 22 Oct 2024 02:02:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13395: Adds USE APACHE COMPONENTS=true in all-build-options job
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21842 )
Change subject: IMPALA-13395: Adds USE_APACHE_COMPONENTS=true in all-build-options job
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11061/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica516a7554bfe9fa0710b5a437c302934a13c08d
Gerrit-Change-Number: 21842
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 21 Oct 2024 20:57:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13395: Adds USE APACHE COMPONENTS=true in all-build-options job
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21842 )
Change subject: IMPALA-13395: Adds USE_APACHE_COMPONENTS=true in all-build-options job
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21842/1/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/21842/1/bin/impala-config.sh@397
PS1, Line 397: export USE_APACHE_OZONE=false
> I got it. Thanks to reply!
I don't see any other test environments that set these flags.
--
To view, visit http://gerrit.cloudera.org:8080/21842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica516a7554bfe9fa0710b5a437c302934a13c08d
Gerrit-Change-Number: 21842
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 21 Oct 2024 20:57:28 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13395: Adds USE APACHE COMPONENTS=true in all-build-options job
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21842 )
Change subject: IMPALA-13395: Adds USE_APACHE_COMPONENTS=true in all-build-options job
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16997/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica516a7554bfe9fa0710b5a437c302934a13c08d
Gerrit-Change-Number: 21842
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sun, 22 Sep 2024 10:23:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13395: Adds USE APACHE COMPONENTS=true in all-build-options job
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has removed a vote on this change.
Change subject: IMPALA-13395: Adds USE_APACHE_COMPONENTS=true in all-build-options job
......................................................................
Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
--
To view, visit http://gerrit.cloudera.org:8080/21842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ica516a7554bfe9fa0710b5a437c302934a13c08d
Gerrit-Change-Number: 21842
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-13395: Adds USE APACHE COMPONENTS=true in all-build-options job
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21842 )
Change subject: IMPALA-13395: Adds USE_APACHE_COMPONENTS=true in all-build-options job
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica516a7554bfe9fa0710b5a437c302934a13c08d
Gerrit-Change-Number: 21842
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 21 Oct 2024 20:57:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13395: Adds USE APACHE COMPONENTS=true in all-build-options job
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
eubnara@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/21842 )
Change subject: IMPALA-13395: Adds USE_APACHE_COMPONENTS=true in all-build-options job
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21842/1/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/21842/1/bin/impala-config.sh@397
PS1, Line 397: export USE_APACHE_OZONE=false
Is there no need to support to select apache component individually?
--
To view, visit http://gerrit.cloudera.org:8080/21842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica516a7554bfe9fa0710b5a437c302934a13c08d
Gerrit-Change-Number: 21842
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 23 Sep 2024 23:48:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13395: Adds USE APACHE COMPONENTS=true in all-build-options job
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21842 )
Change subject: IMPALA-13395: Adds USE_APACHE_COMPONENTS=true in all-build-options job
......................................................................
IMPALA-13395: Adds USE_APACHE_COMPONENTS=true in all-build-options job
The all-build-options-ub2004 job verifies builds with USE_APACHE_HIVE
being true and false. This extends it to use the new var,
USE_APACHE_COMPONENTS intead.
Explicitly set USE_APACHE_* based on the value of USE_APACHE_COMPONENTS
so we won't mess up env vars when switching between builds of different
USE_APACHE_COMPONENTS values.
Change-Id: Ica516a7554bfe9fa0710b5a437c302934a13c08d
Reviewed-on: http://gerrit.cloudera.org:8080/21842
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
M bin/impala-config.sh
M bin/jenkins/build-all-flag-combinations.sh
2 files changed, 18 insertions(+), 18 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved
Michael Smith: Verified
--
To view, visit http://gerrit.cloudera.org:8080/21842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica516a7554bfe9fa0710b5a437c302934a13c08d
Gerrit-Change-Number: 21842
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-13395: Adds USE APACHE COMPONENTS=true in all-build-options job
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21842 )
Change subject: IMPALA-13395: Adds USE_APACHE_COMPONENTS=true in all-build-options job
......................................................................
Patch Set 2: Verified+1
Overriding unrelated instance of IMPALA-12187.
--
To view, visit http://gerrit.cloudera.org:8080/21842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica516a7554bfe9fa0710b5a437c302934a13c08d
Gerrit-Change-Number: 21842
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 22 Oct 2024 16:16:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13395: Adds USE APACHE COMPONENTS=true in all-build-options job
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
eubnara@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/21842 )
Change subject: IMPALA-13395: Adds USE_APACHE_COMPONENTS=true in all-build-options job
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21842/1/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/21842/1/bin/impala-config.sh@397
PS1, Line 397: export USE_APACHE_OZONE=false
> We can support that in the future. The current problem is when we switch th
I got it. Thanks to reply!
--
To view, visit http://gerrit.cloudera.org:8080/21842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica516a7554bfe9fa0710b5a437c302934a13c08d
Gerrit-Change-Number: 21842
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sun, 13 Oct 2024 05:20:22 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13395: Adds USE APACHE COMPONENTS=true in all-build-options job
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21842 )
Change subject: IMPALA-13395: Adds USE_APACHE_COMPONENTS=true in all-build-options job
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21842/1/bin/impala-config.sh
File bin/impala-config.sh:
http://gerrit.cloudera.org:8080/#/c/21842/1/bin/impala-config.sh@397
PS1, Line 397: export USE_APACHE_OZONE=false
> Is there no need to support to select apache component individually?
We can support that in the future. The current problem is when we switch the build between Apache and CDH components, the env vars remains unchanged, which causes build failures.
--
To view, visit http://gerrit.cloudera.org:8080/21842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica516a7554bfe9fa0710b5a437c302934a13c08d
Gerrit-Change-Number: 21842
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 11 Oct 2024 11:16:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13395: Adds USE APACHE COMPONENTS=true in all-build-options job
Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21842 )
Change subject: IMPALA-13395: Adds USE_APACHE_COMPONENTS=true in all-build-options job
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica516a7554bfe9fa0710b5a437c302934a13c08d
Gerrit-Change-Number: 21842
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Anonymous Coward <eu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 16 Oct 2024 21:56:57 +0000
Gerrit-HasComments: No