[GitHub] [accumulo] milleruntime commented on a change in pull request #1259: update du command to use hdfs iterator

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #1259:
URL: https://github.com/apache/accumulo/pull/1259#discussion_r770588905



##########
File path: server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java
##########
@@ -277,6 +279,12 @@ public Volume getVolumeByPath(Path path) {
     return volumesByName;
   }
 
+  @Override
+  public RemoteIterator<LocatedFileStatus> listStatus(final Path path, final boolean recursive)
+      throws IOException {
+    return getVolumeByPath(path).getFileSystem().listFiles(path, recursive);

Review comment:
       I was looking into this and I am not sure it does. The globStatus methods in the hadoop API don't return an iterator. Some of the performance problems with this utility could be with the globbing. I found this open issue: https://issues.apache.org/jira/browse/HADOOP-17275




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org