[GitHub] [couchdb-documentation] flimzy commented on a diff in pull request #756: Add replicator bulk_get stats

[GitBox <gi...@apache.org>]

flimzy commented on code in PR #756:
URL: https://github.com/apache/couchdb-documentation/pull/756#discussion_r961070438


##########
src/api/server/common.rst:
##########
@@ -728,6 +734,10 @@
     :json number doc_write_failures: Number of document write failures
     :json number docs_read:  Number of documents read
     :json number docs_written:  Number of documents written to target
+    :json number bulk_get_attempts: The count of attempted doc fetches
+        with ``_bulk_get``.

Review Comment:
   Is this the number of times `_bulk_get` is called, or the number of docs fetched with `_bulk_get`?  I suspect the former, but it might be nice to make that a bit more explicit.



##########
src/api/server/common.rst:
##########
@@ -728,6 +734,10 @@
     :json number doc_write_failures: Number of document write failures
     :json number docs_read:  Number of documents read
     :json number docs_written:  Number of documents written to target
+    :json number bulk_get_attempts: The count of attempted doc fetches
+        with ``_bulk_get``.
+    :json number bulk_get_docs: The count of successful docs read with
+        ``_bulk_get``.

Review Comment:
   It's interesting (not a problem, necessiarly) that we report the number of successes here, but the number of failures for other metrics.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org