[GitHub] [age] panosfol commented on issue #995: Research functions that extracts label ID

["panosfol (via GitHub)" <gi...@apache.org>]

panosfol commented on issue #995:
URL: https://github.com/apache/age/issues/995#issuecomment-1627313474

   So i researched the above 3 functions and here is what I found:
   - The `entitiy_exists()` function uses the macro `GET_LABEL_ID` which takes the bit shifted `label_id` and reverses the procedure to get the `label_id` . Here is the macro: `(((uint64)id) >> ENTRY_ID_BITS)`
   - The `get_label_name()` function calls the `get_graphid_label_id()` function that follows the above logic : 
     `return (int32)(((uint64)gid) >> ENTRY_ID_BITS);`
   - The `filter_vertices_on_label_id()` function creates a function call for the function `_extract_label_id`. That function calls the same function as `get_label_name()` to get the `label_id`.
   
   
   According to my solution all of these functions would stay the same but they function arguments would change to include the value from the new column that I suggested instead of the `id`. The value of the new column would hold the `label_id` after the bit shift so we can minimize the changes that we would need apply to the code. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@age.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org