[GitHub] [cassandra] maedhroz commented on a diff in pull request #2255: CASSANDRA-18370 Avoid loading the preferred IP for BulkLoader streaming

["maedhroz (via GitHub)" <gi...@apache.org>]

maedhroz commented on code in PR #2255:
URL: https://github.com/apache/cassandra/pull/2255#discussion_r1153618643


##########
src/java/org/apache/cassandra/streaming/StreamConnectionFactory.java:
##########
@@ -26,4 +26,18 @@
 public interface StreamConnectionFactory
 {
     Channel createConnection(OutboundConnectionSettings template, int messagingVersion) throws IOException;
+
+    /** Provide way to disable getPreferredIP() for tools without access to the system keyspace
+     * <p> 
+     * CASSANDRA-17663 moves calls to SystemKeyspace.getPreferredIP() outside of any threads
+     * that are regularly interrupted.  However the streaming subsystem is also used
+     * by the bulk loader tool, which does not have direct access to the local tables
+     * and uses the client metadata/queries to retrieve it.
+     *
+     * @return true if SystemKeyspace.getPreferredIP() should be used when connecting
+     */
+    default boolean supportsPreferredIp()
+    {
+        return true;

Review Comment:
   Note: Setting this to false fails `RepairErrorsTest`, as it should.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org