You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celeborn.apache.org by GitBox <gi...@apache.org> on 2022/11/23 09:19:44 UTC

[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #999: [CELEBORN-48][BUG] Channel inactive may cause new client use old stream id to fetch data

AngersZhuuuu opened a new pull request, #999:
URL: https://github.com/apache/incubator-celeborn/pull/999

   ### What changes were proposed in this pull request?
   
   
   ### Why are the changes needed?
   
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   ### What are the items that need reviewer attention?
   
   
   ### Related issues.
   
   
   ### Related pull requests.
   
   
   ### How was this patch tested?
   
   
   /cc @related-reviewer
   
   /assign @main-reviewer
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #999: [CELEBORN-48][BUG] Channel inactive may cause new client use old stream id to fetch data

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on PR #999:
URL: https://github.com/apache/incubator-celeborn/pull/999#issuecomment-1324785726

   duplicate  with https://github.com/apache/incubator-celeborn/pull/1000, close this one


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] AngersZhuuuu closed pull request #999: [CELEBORN-50][FOLLOWUP] Channel inactive may cause new client use old stream id to fetch data

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu closed pull request #999: [CELEBORN-50][FOLLOWUP] Channel inactive may cause new client use old stream id to fetch data
URL: https://github.com/apache/incubator-celeborn/pull/999


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] AngersZhuuuu closed pull request #999: [CELEBORN-48][BUG] Channel inactive may cause new client use old stream id to fetch data

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu closed pull request #999: [CELEBORN-48][BUG] Channel inactive may cause new client use old stream id to fetch data
URL: https://github.com/apache/incubator-celeborn/pull/999


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #999: [CELEBORN-48][BUG] Channel inactive may cause new client use old stream id to fetch data

Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on code in PR #999:
URL: https://github.com/apache/incubator-celeborn/pull/999#discussion_r1030198834


##########
client/src/main/java/org/apache/celeborn/client/read/Replica.java:
##########
@@ -57,7 +60,21 @@ class Replica {
 
   public synchronized TransportClient getOrOpenStream() throws IOException, InterruptedException {
     if (client == null || !client.isActive()) {
+      if (client != null) {
+        logger.error(
+            "Current channel from "
+                + client.getChannel().localAddress()
+                + " to "
+                + client.getChannel().remoteAddress()
+                + " for "
+                + this
+                + " is not active.");
+      }
       client = clientFactory.createClient(location.getHost(), location.getFetchPort());
+      // When changing client, the origin client's corresponding streamId may be removed
+      // by channel inactive. Replica should request a new StreamHandle for the new client again.
+      // Newly returned numChunks should be the same.
+      streamHandle = null;

Review Comment:
   @waitinfuture @FMX 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org