[GitHub] [solr] dsmiley commented on pull request #1245: SOLR-16567: KnnQueryParser support for both pre-filters and post-filter

[GitBox <gi...@apache.org>]

dsmiley commented on PR #1245:
URL: https://github.com/apache/solr/pull/1245#issuecomment-1370501863

   I read your response to my question:
   > (me:) Are you trying to basically move certain FQs out of their top level position and into/embedded in a particular parsed query?
   
   You didn't give a simple yes-no answer but my interpretation is definitely a "yes".  Another possible approach is to make embedding specific filter queries very explicit -- put them in local-params of the KNN query parser *instead of* standard 'fq' at the top of the request.  This makes it clear there's no double-interpretation problem and it provides a great deal of control to the Solr user/dev.  But of course it's less friendly / more complex.  I don't know enough about KNN to know if certain expensive filter queries (that are not post-filters) might be better off happening ~after the KNN instead of "pre".  This is not supported by KNN today but could be.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org