You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/08/02 18:56:21 UTC

[GitHub] [mynewt-nimble] hardik-proxy commented on a change in pull request #543: mesh: moved defined number of segment retransmissions to syscfg

hardik-proxy commented on a change in pull request #543: mesh: moved defined number of segment retransmissions to syscfg
URL: https://github.com/apache/mynewt-nimble/pull/543#discussion_r310258627
 
 

 ##########
 File path: nimble/host/mesh/syscfg.yml
 ##########
 @@ -524,6 +524,11 @@ syscfg.defs:
             Secondary sysinit stage for BLE mesh functionality.
         value: 1000
 
+    BLE_MESH_SEG_RETRANSMIT_ATTEMPTS:
+        description: >
+            Number of retransmit attempts (after the initial transmit) per segment.
 
 Review comment:
   @rymanluk I was going through the spec to confirm the minimum allowed value by the spec. I couldn't found anything specific about 'minimum number of segment re-transmission'. Although, the spec states that the TTL value for relaying a message should be minimum 2. 
   
   Also I have tried setting BLE_MESH_SEG_RETRANSMIT_ATTEMPTS to 0 and it worked without any error. 
   
   And yes you are right, re-transmissions happens only when segments are not acked. As I am publishing over a group address and my message is of 3 segments if I set BLE_MESH_SEG_RETRANSMIT_ATTEMPTS to 4, the time difference between receiving a message is around 10 to 15 secs but if I set the value to 0 it just ~3.5 sec. So I preferred sending a message multiple times rather than sending each segment multiple times. Is this an incorrect approach?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services