You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/10 16:04:02 UTC
[GitHub] [shardingsphere] codecov-io commented on pull request #8566: Add authentication SPI for external authentication
codecov-io commented on pull request #8566:
URL: https://github.com/apache/shardingsphere/pull/8566#issuecomment-742614731
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8566?src=pr&el=h1) Report
> Merging [#8566](https://codecov.io/gh/apache/shardingsphere/pull/8566?src=pr&el=desc) (2faf3ce) into [master](https://codecov.io/gh/apache/shardingsphere/commit/2a8002c9bac5ce9dd96a7cb1b8a3d3a395ba401a?el=desc) (2a8002c) will **decrease** coverage by `0.00%`.
> The diff coverage is `82.14%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/8566?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8566 +/- ##
============================================
- Coverage 72.22% 72.22% -0.01%
Complexity 602 602
============================================
Files 1546 1547 +1
Lines 24523 24537 +14
Branches 4324 4325 +1
============================================
+ Hits 17711 17721 +10
- Misses 5655 5659 +4
Partials 1157 1157
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8566?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...e/context/metadata/GovernanceMetaDataContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/8566/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvbnRleHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29udGV4dC9tZXRhZGF0YS9Hb3Zlcm5hbmNlTWV0YURhdGFDb250ZXh0cy5qYXZh) | `92.53% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ingsphere/governance/core/config/ConfigCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/8566/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9jb25maWcvQ29uZmlnQ2VudGVyLmphdmE=) | `66.43% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...config/listener/AuthenticationChangedListener.java](https://codecov.io/gh/apache/shardingsphere/pull/8566/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9jb25maWcvbGlzdGVuZXIvQXV0aGVudGljYXRpb25DaGFuZ2VkTGlzdGVuZXIuamF2YQ==) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...phere/governance/core/facade/GovernanceFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/8566/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9mYWNhZGUvR292ZXJuYW5jZUZhY2FkZS5qYXZh) | `80.76% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...hardingsphere/infra/auth/AuthenticationEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/8566/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9hdXRoL0F1dGhlbnRpY2F0aW9uRW5naW5lLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...n/yaml/config/YamlAuthenticationConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/8566/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9hdXRoL2J1aWx0aW4veWFtbC9jb25maWcvWWFtbEF1dGhlbnRpY2F0aW9uQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
| [...roxy/config/yaml/YamlProxyServerConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/8566/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9jb25maWcveWFtbC9ZYW1sUHJveHlTZXJ2ZXJDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...gsphere/proxy/config/ProxyConfigurationLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/8566/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9jb25maWcvUHJveHlDb25maWd1cmF0aW9uTG9hZGVyLmphdmE=) | `81.81% <50.00%> (+0.56%)` | `0.00 <0.00> (ø)` | |
| [...here/infra/auth/builtin/DefaultAuthentication.java](https://codecov.io/gh/apache/shardingsphere/pull/8566/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9hdXRoL2J1aWx0aW4vRGVmYXVsdEF1dGhlbnRpY2F0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...uth/builtin/yaml/config/YamlUserConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/8566/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9hdXRoL2J1aWx0aW4veWFtbC9jb25maWcvWWFtbFVzZXJDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| ... and [9 more](https://codecov.io/gh/apache/shardingsphere/pull/8566/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8566?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8566?src=pr&el=footer). Last update [2a8002c...2faf3ce](https://codecov.io/gh/apache/shardingsphere/pull/8566?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org