You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@nemo.apache.org by GitBox <gi...@apache.org> on 2022/08/01 03:44:36 UTC

[GitHub] [incubator-nemo] wonook commented on a diff in pull request #323: [MINOR] Bump Library Versions

wonook commented on code in PR #323:
URL: https://github.com/apache/incubator-nemo/pull/323#discussion_r934115515


##########
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/AbstractDoFnTransform.java:
##########
@@ -281,8 +281,7 @@ public TimerInternals timerInternals() {
     final DoFn wrappedDoFn = wrapDoFn(doFn);
 
     // invoker
-    doFnInvoker = DoFnInvokers.invokerFor(wrappedDoFn);
-    doFnInvoker.invokeSetup();
+    doFnInvoker = DoFnInvokers.tryInvokeSetupFor(wrappedDoFn); // options?

Review Comment:
   ![image](https://user-images.githubusercontent.com/6691311/182068077-ce4bc5cc-8dfd-4542-a1ae-6d4a610cc29c.png)
   As you can see from the source code, the exception is already handled inside the function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@nemo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org