[GitHub] [tez] pgaref commented on a change in pull request #103: TEZ-4282: Possible NPE in LocalClient after TEZ-4236

[GitBox <gi...@apache.org>]

pgaref commented on a change in pull request #103:
URL: https://github.com/apache/tez/pull/103#discussion_r570491291



##########
File path: tez-dag/src/main/java/org/apache/tez/client/LocalClient.java
##########
@@ -438,7 +447,9 @@ public DAGStatus apply(Set<StatusGetOpts> statusOpts, Long timeout) {
   public boolean shutdownSession(Configuration configuration, ApplicationId sessionAppId,
       UserGroupInformation ugi) throws TezException, IOException, ServiceException {
     if (isLocalWithoutNetwork) {
-      clientHandler.shutdownAM();
+      if (clientHandler != null){
+        clientHandler.shutdownAM();
+      }
       return true;
     } else {

Review comment:
       If - else can be simplified here (else not needed)

##########
File path: tez-dag/src/main/java/org/apache/tez/client/LocalClient.java
##########
@@ -403,7 +405,14 @@ protected DAGAppMaster createDAGAppMaster(ApplicationAttemptId applicationAttemp
   @Override
   public TezAppMasterStatus getAMStatus(Configuration configuration, ApplicationId appId,
       UserGroupInformation ugi) throws TezException, ServiceException, IOException {
-    return clientHandler.getTezAppMasterStatus();
+    if (isLocalWithoutNetwork) {
+      if (clientHandler == null) {
+        return TezAppMasterStatus.INITIALIZING;
+      }
+      return clientHandler.getTezAppMasterStatus();
+    } else {

Review comment:
       if - else can be simplified (no need for else.
   Are we sure we need the super. getAMStatus call? I would assume that a FrameworkClient would call its own method right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org