You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "msaravanan77 (via GitHub)" <gi...@apache.org> on 2025/10/23 16:00:18 UTC
[PR] GUACAMOLE-2136: Improve C standards compliance [guacamole-server]
msaravanan77 opened a new pull request, #620:
URL: https://github.com/apache/guacamole-server/pull/620
This commit addresses C standard compliance issues identified when building with Clang 18.1.3 and strict compiler flags.
Changes made:
1. Added 'void' keyword to all function declarations with no parameters to comply with modern C standards (fixes -Wstrict-prototypes warnings)
2. Removed unused 'flushed' variable in surface.c that was set but never used (fixes -Wunused-but-set-variable warning)
The code now builds cleanly with both GCC and Clang when using -Werror -Wstrict-prototypes flags.
## JIRA Issue
https://issues.apache.org/jira/browse/GUACAMOLE-2136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2136: Improve C standards compliance [guacamole-server]
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper merged PR #620:
URL: https://github.com/apache/guacamole-server/pull/620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2136: Improve C standards compliance [guacamole-server]
Posted by "msaravanan77 (via GitHub)" <gi...@apache.org>.
msaravanan77 commented on PR #620:
URL: https://github.com/apache/guacamole-server/pull/620#issuecomment-3450754216
> I think `patch` might be appropriate for these changes, but otherwise no concerns for me.
@mike-jumper Rebased onto the patch branch as suggested. Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org