You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/08/16 18:06:10 UTC
[GitHub] [iceberg] kbendick opened a new pull request, #5552: Flink - Suppress Nanosecond Warning for TimestampTz ORC writer
kbendick opened a new pull request, #5552:
URL: https://github.com/apache/iceberg/pull/5552
In the TimestampTz ORC writer, we are intentionally accessing _just_ the nanoseconds of the `Instant` method, and not trying to get the whole instant value in nanoseconds.
Additionally, we are storing the time in epoch millis, which is correct for timestamptz.
So we should suppress the warning `JavaInstantGetSecondsGetNanos` when storing the `cv.nanos` area.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pvary commented on pull request #5552: Flink - Suppress Nanosecond Warning for TimestampTz ORC writer
Posted by GitBox <gi...@apache.org>.
pvary commented on PR #5552:
URL: https://github.com/apache/iceberg/pull/5552#issuecomment-1217529013
Thanks @kbendick for the fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pvary merged pull request #5552: Flink - Suppress Nanosecond Warning for TimestampTz ORC writer
Posted by GitBox <gi...@apache.org>.
pvary merged PR #5552:
URL: https://github.com/apache/iceberg/pull/5552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org