You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/21 13:04:26 UTC

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6010: env_dup: fix copying of parent's env to child with ARCH_ADDRENV=y

pkarashchenko commented on code in PR #6010:
URL: https://github.com/apache/incubator-nuttx/pull/6010#discussion_r855162688


##########
binfmt/binfmt_execmodule.c:
##########
@@ -150,15 +151,26 @@ int exec_module(FAR const struct binary_s *binp,
         }
     }
 
+  /* Make a copy of the environment here */
+
+  if (envp || (envp = get_environ_ptr()))

Review Comment:
   @xiaoxiang781216 should we use `environ` here instead of `get_environ_ptr` in https://github.com/apache/incubator-nuttx/pull/6119 ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org