You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@river.apache.org by "Jim Hurley (JIRA)" <ji...@apache.org> on 2007/08/14 21:47:30 UTC
[jira] Created: (RIVER-245) Unicast discovery should close socket
in case of connection exception.
Unicast discovery should close socket in case of connection exception.
----------------------------------------------------------------------
Key: RIVER-245
URL: https://issues.apache.org/jira/browse/RIVER-245
Project: River
Issue Type: Bug
Components: com_sun_jini_discovery
Affects Versions: jtsk_2.1
Reporter: Jim Hurley
Priority: Minor
Bugtraq ID [6284047|http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6284047]
The MultiIPDiscovery class which is used by ConstrainableLookupLocator, LookupDiscovery and LookupLocatorDiscovery does not close the socket it created on encountering an exception during connect. Ordinarily this should not result in the socket file descriptor being 'leaked' (at least until finalization). However, this should still be cleaned up.
This behavior would be consistent to the endpoint implementations too.
We should also close those socket in case there is an exception while setting the SO_TIMEOUT (setSoTimeout call).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (RIVER-245) Unicast discovery should close socket in
case of connection exception.
Posted by "Peter Firmstone (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Firmstone closed RIVER-245.
---------------------------------
> Unicast discovery should close socket in case of connection exception.
> ----------------------------------------------------------------------
>
> Key: RIVER-245
> URL: https://issues.apache.org/jira/browse/RIVER-245
> Project: River
> Issue Type: Bug
> Components: com_sun_jini_discovery
> Affects Versions: jtsk_2.1
> Reporter: Jim Hurley
> Assignee: Thomas Vinod Johnson
> Priority: Minor
> Fix For: AR2
>
> Attachments: RIVER-245.patch
>
>
> Bugtraq ID [6284047|http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6284047]
> The MultiIPDiscovery class which is used by ConstrainableLookupLocator, LookupDiscovery and LookupLocatorDiscovery does not close the socket it created on encountering an exception during connect. Ordinarily this should not result in the socket file descriptor being 'leaked' (at least until finalization). However, this should still be cleaned up.
> This behavior would be consistent to the endpoint implementations too.
> We should also close those socket in case there is an exception while setting the SO_TIMEOUT (setSoTimeout call).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (RIVER-245) Unicast discovery should close socket
in case of connection exception.
Posted by "Thomas Vinod Johnson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Vinod Johnson reopened RIVER-245:
----------------------------------------
Shouldn't have 'resolved', just set the Fix version to AR2.
> Unicast discovery should close socket in case of connection exception.
> ----------------------------------------------------------------------
>
> Key: RIVER-245
> URL: https://issues.apache.org/jira/browse/RIVER-245
> Project: River
> Issue Type: Bug
> Components: com_sun_jini_discovery
> Affects Versions: jtsk_2.1
> Reporter: Jim Hurley
> Assignee: Thomas Vinod Johnson
> Priority: Minor
> Fix For: AR2
>
>
> Bugtraq ID [6284047|http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6284047]
> The MultiIPDiscovery class which is used by ConstrainableLookupLocator, LookupDiscovery and LookupLocatorDiscovery does not close the socket it created on encountering an exception during connect. Ordinarily this should not result in the socket file descriptor being 'leaked' (at least until finalization). However, this should still be cleaned up.
> This behavior would be consistent to the endpoint implementations too.
> We should also close those socket in case there is an exception while setting the SO_TIMEOUT (setSoTimeout call).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (RIVER-245) Unicast discovery should close socket
in case of connection exception.
Posted by "Thomas Vinod Johnson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Vinod Johnson reassigned RIVER-245:
------------------------------------------
Assignee: Thomas Vinod Johnson
> Unicast discovery should close socket in case of connection exception.
> ----------------------------------------------------------------------
>
> Key: RIVER-245
> URL: https://issues.apache.org/jira/browse/RIVER-245
> Project: River
> Issue Type: Bug
> Components: com_sun_jini_discovery
> Affects Versions: jtsk_2.1
> Reporter: Jim Hurley
> Assignee: Thomas Vinod Johnson
> Priority: Minor
>
> Bugtraq ID [6284047|http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6284047]
> The MultiIPDiscovery class which is used by ConstrainableLookupLocator, LookupDiscovery and LookupLocatorDiscovery does not close the socket it created on encountering an exception during connect. Ordinarily this should not result in the socket file descriptor being 'leaked' (at least until finalization). However, this should still be cleaned up.
> This behavior would be consistent to the endpoint implementations too.
> We should also close those socket in case there is an exception while setting the SO_TIMEOUT (setSoTimeout call).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (RIVER-245) Unicast discovery should close socket
in case of connection exception.
Posted by Thomas Vinod Johnson <Th...@Sun.COM>.
Mark Brouwer wrote:
> Thomas Vinod Johnson wrote:
>> Mark Brouwer wrote:
>>> Thomas Vinod Johnson (JIRA) wrote:
>>>> [
>>>> https://issues.apache.org/jira/browse/RIVER-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>>>> ]
>>>>
>>>> Thomas Vinod Johnson updated RIVER-245:
>>>> ---------------------------------------
>>>>
>>>> Attachment: RIVER-245.patch
>>>>
>>>> Patch file for this issue.
>>>
>>> Patch looks good.
>> Thanks. I guess I'm having a problem committing, though. I tried
>> three times with what I think is my user name and password. I hope
>> this didn't lock my account or anything.
>
> Hi Vinod,
>
> I think you are using the wrong account id. Ik looked at the home
> directories at people.apache.org and I think your UNIX user id is
> 'vinod'. you must have had an email in the past from root@apache.org
> that says:
>
> "Dear Vinod Johnson,
>
> We're glad to tell you that your account has been created and is now
> available for use. Your login details are:
>
> username: vinod
> password: xxxxxxxxx"
>
> And then some instructions how to change you UNIX password and svn
> password. And what to do if things go wrong.
>
> Could luck and if you don't have the email I'll forward it to you. Let
> me know.
Thanks. I suspected I might have been doing something stupid like that.
I found the mail and I believe I have successfully committed.
Re: [jira] Updated: (RIVER-245) Unicast discovery should close socket
in case of connection exception.
Posted by Mark Brouwer <ma...@cheiron.org>.
Thomas Vinod Johnson wrote:
> Mark Brouwer wrote:
>> Thomas Vinod Johnson (JIRA) wrote:
>>> [
>>> https://issues.apache.org/jira/browse/RIVER-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>>> ]
>>>
>>> Thomas Vinod Johnson updated RIVER-245:
>>> ---------------------------------------
>>>
>>> Attachment: RIVER-245.patch
>>>
>>> Patch file for this issue.
>>
>> Patch looks good.
> Thanks. I guess I'm having a problem committing, though. I tried three
> times with what I think is my user name and password. I hope this didn't
> lock my account or anything.
Hi Vinod,
I think you are using the wrong account id. Ik looked at the home
directories at people.apache.org and I think your UNIX user id is
'vinod'. you must have had an email in the past from root@apache.org
that says:
"Dear Vinod Johnson,
We're glad to tell you that your account has been created and is now
available for use. Your login details are:
username: vinod
password: xxxxxxxxx"
And then some instructions how to change you UNIX password and svn
password. And what to do if things go wrong.
Could luck and if you don't have the email I'll forward it to you. Let
me know.
--
Mark
Re: [jira] Updated: (RIVER-245) Unicast discovery should close socket
in case of connection exception.
Posted by Thomas Vinod Johnson <Th...@Sun.COM>.
Mark Brouwer wrote:
> Thomas Vinod Johnson (JIRA) wrote:
>> [
>> https://issues.apache.org/jira/browse/RIVER-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>> ]
>>
>> Thomas Vinod Johnson updated RIVER-245:
>> ---------------------------------------
>>
>> Attachment: RIVER-245.patch
>>
>> Patch file for this issue.
>
> Patch looks good.
Thanks. I guess I'm having a problem committing, though. I tried three
times with what I think is my user name and password. I hope this didn't
lock my account or anything.
/pkg/local/bin/svn commit --username vinodjohnson -m "Fix for RIVER-245"
Error validating server certificate for 'https://svn.apache.org:443':
- The certificate is not issued by a trusted authority. Use the
fingerprint to validate the certificate manually!
Certificate information:
- Hostname: svn.apache.org
- Valid: from Fri, 26 Jan 2007 14:18:55 GMT until Mon, 26 Jan 2009
14:18:55 GMT - Issuer: http://www.starfieldtech.com/repository,
Starfield Technologies, Inc., Scottsdale, Arizona, US
- Fingerprint: a7:a5:3f:1a:ae:bb:98:b2:f3:ec:91:1b:63:29:2d:e8:58:b6:53:28
(R)eject, accept (t)emporarily or accept (p)ermanently? t
Authentication realm: <https://svn.apache.org:443> ASF Committers
Password for 'vinodjohnson':
Authentication realm: <https://svn.apache.org:443> ASF Committers
Username: vinodjohnson
Password for 'vinodjohnson':
Authentication realm: <https://svn.apache.org:443> ASF Committers
Username: vinodjohnson
Password for 'vinodjohnson':
svn: Commit failed (details follow):
svn: MKACTIVITY of
'/repos/asf/!svn/act/337fc982-f596-4e0a-a4fa-b39cf2229d16':
authorization failed (https://svn.apache.org)
Re: [jira] Updated: (RIVER-245) Unicast discovery should close socket
in case of connection exception.
Posted by Mark Brouwer <ma...@cheiron.org>.
Thomas Vinod Johnson (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/RIVER-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Thomas Vinod Johnson updated RIVER-245:
> ---------------------------------------
>
> Attachment: RIVER-245.patch
>
> Patch file for this issue.
Patch looks good.
--
Mark
[jira] Updated: (RIVER-245) Unicast discovery should close socket
in case of connection exception.
Posted by "Thomas Vinod Johnson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Vinod Johnson updated RIVER-245:
---------------------------------------
Attachment: RIVER-245.patch
Patch file for this issue.
> Unicast discovery should close socket in case of connection exception.
> ----------------------------------------------------------------------
>
> Key: RIVER-245
> URL: https://issues.apache.org/jira/browse/RIVER-245
> Project: River
> Issue Type: Bug
> Components: com_sun_jini_discovery
> Affects Versions: jtsk_2.1
> Reporter: Jim Hurley
> Assignee: Thomas Vinod Johnson
> Priority: Minor
> Fix For: AR2
>
> Attachments: RIVER-245.patch
>
>
> Bugtraq ID [6284047|http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6284047]
> The MultiIPDiscovery class which is used by ConstrainableLookupLocator, LookupDiscovery and LookupLocatorDiscovery does not close the socket it created on encountering an exception during connect. Ordinarily this should not result in the socket file descriptor being 'leaked' (at least until finalization). However, this should still be cleaned up.
> This behavior would be consistent to the endpoint implementations too.
> We should also close those socket in case there is an exception while setting the SO_TIMEOUT (setSoTimeout call).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (RIVER-245) Unicast discovery should close
socket in case of connection exception.
Posted by "Thomas Vinod Johnson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on RIVER-245 started by Thomas Vinod Johnson.
> Unicast discovery should close socket in case of connection exception.
> ----------------------------------------------------------------------
>
> Key: RIVER-245
> URL: https://issues.apache.org/jira/browse/RIVER-245
> Project: River
> Issue Type: Bug
> Components: com_sun_jini_discovery
> Affects Versions: jtsk_2.1
> Reporter: Jim Hurley
> Assignee: Thomas Vinod Johnson
> Priority: Minor
>
> Bugtraq ID [6284047|http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6284047]
> The MultiIPDiscovery class which is used by ConstrainableLookupLocator, LookupDiscovery and LookupLocatorDiscovery does not close the socket it created on encountering an exception during connect. Ordinarily this should not result in the socket file descriptor being 'leaked' (at least until finalization). However, this should still be cleaned up.
> This behavior would be consistent to the endpoint implementations too.
> We should also close those socket in case there is an exception while setting the SO_TIMEOUT (setSoTimeout call).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (RIVER-245) Unicast discovery should close socket
in case of connection exception.
Posted by "Thomas Vinod Johnson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Vinod Johnson resolved RIVER-245.
----------------------------------------
Resolution: Fixed
Submitted patch
> Unicast discovery should close socket in case of connection exception.
> ----------------------------------------------------------------------
>
> Key: RIVER-245
> URL: https://issues.apache.org/jira/browse/RIVER-245
> Project: River
> Issue Type: Bug
> Components: com_sun_jini_discovery
> Affects Versions: jtsk_2.1
> Reporter: Jim Hurley
> Assignee: Thomas Vinod Johnson
> Priority: Minor
> Fix For: AR2
>
> Attachments: RIVER-245.patch
>
>
> Bugtraq ID [6284047|http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6284047]
> The MultiIPDiscovery class which is used by ConstrainableLookupLocator, LookupDiscovery and LookupLocatorDiscovery does not close the socket it created on encountering an exception during connect. Ordinarily this should not result in the socket file descriptor being 'leaked' (at least until finalization). However, this should still be cleaned up.
> This behavior would be consistent to the endpoint implementations too.
> We should also close those socket in case there is an exception while setting the SO_TIMEOUT (setSoTimeout call).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (RIVER-245) Unicast discovery should close socket
in case of connection exception.
Posted by "Thomas Vinod Johnson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RIVER-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Vinod Johnson resolved RIVER-245.
----------------------------------------
Resolution: Fixed
Fix Version/s: AR2
> Unicast discovery should close socket in case of connection exception.
> ----------------------------------------------------------------------
>
> Key: RIVER-245
> URL: https://issues.apache.org/jira/browse/RIVER-245
> Project: River
> Issue Type: Bug
> Components: com_sun_jini_discovery
> Affects Versions: jtsk_2.1
> Reporter: Jim Hurley
> Assignee: Thomas Vinod Johnson
> Priority: Minor
> Fix For: AR2
>
>
> Bugtraq ID [6284047|http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6284047]
> The MultiIPDiscovery class which is used by ConstrainableLookupLocator, LookupDiscovery and LookupLocatorDiscovery does not close the socket it created on encountering an exception during connect. Ordinarily this should not result in the socket file descriptor being 'leaked' (at least until finalization). However, this should still be cleaned up.
> This behavior would be consistent to the endpoint implementations too.
> We should also close those socket in case there is an exception while setting the SO_TIMEOUT (setSoTimeout call).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.