You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2019/11/13 15:57:41 UTC

[GitHub] [storm] srdo commented on issue #3165: 'kafkaSpoutConfig' can be 'protected'

srdo commented on issue #3165: 'kafkaSpoutConfig' can be 'protected'
URL: https://github.com/apache/storm/pull/3165#issuecomment-553466659
 
 
   I'm not sure about this. The spout wasn't really written with subclassing in mind, and the majority of the implementation is private. I also don't think we want to guarantee that we won't break the internal implementation of the spout in minor/patch releases. If you have a use case, maybe we could add a hook somewhere instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services